Bug 2223785 - Review Request: rust-fdeflate - Fast specialized deflate implementation
Summary: Review Request: rust-fdeflate - Fast specialized deflate implementation
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/fdeflate
Depends On:
Blocks: 2185687
TreeView+ depends on / blocked
Reported: 2023-07-18 22:38 UTC by Fabio Valentini
Modified: 2023-07-27 12:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2023-07-27 12:35:32 UTC
Type: ---
davide: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2023-07-18 22:38:23 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-fdeflate.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-fdeflate-0.3.0-1.fc38.src.rpm

Fast specialized deflate implementation.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-07-18 22:38:25 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103530844

Comment 2 Fedora Review Service 2023-07-18 22:42:40 UTC
Copr build:

Build log:

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

This comment was created by the fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2023-07-26 22:17:31 UTC
Taking this review

Comment 4 Davide Cavalca 2023-07-26 22:19:39 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines



Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2023-07-27 11:03:45 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fdeflate

Comment 6 Fabio Valentini 2023-07-27 12:35:32 UTC
Imported and built:

Note You need to log in before you can comment on or make changes to this bug.