Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/blackbox/fedora-rawhide-x86_64/06188838-blackbox-terminal/blackbox-terminal.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/blackbox/fedora-rawhide-x86_64/06188838-blackbox-terminal/blackbox-terminal-0.14.0-1.fc39.src.rpm Description: Black Box is an elegant and customizable terminal for GNOME. Fedora Account System Username: carlwgeorge
Copr build: https://copr.fedorainfracloud.org/coprs/build/6188848 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224163-blackbox-terminal/fedora-rawhide-x86_64/06188848-blackbox-terminal/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to include an upstream PR to rename the executable, to avoid conflicts with the blackbox window manager. https://gitlab.gnome.org/raggesilver/blackbox/-/merge_requests/122 Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/blackbox/fedora-rawhide-x86_64/06188971-blackbox-terminal/blackbox-terminal.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/blackbox/fedora-rawhide-x86_64/06188971-blackbox-terminal/blackbox-terminal-0.14.0-1.fc39.src.rpm
Created attachment 1976649 [details] The .spec file difference from Copr build 6188848 to 6188993
Copr build: https://copr.fedorainfracloud.org/coprs/build/6188993 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224163-blackbox-terminal/fedora-rawhide-x86_64/06188993-blackbox-terminal/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
pqmarble (a build requirement for this package) has been reviewed [0] and built in rawhide [1]. It's available now for mock builds if you enable the "local" repo in the rawhide mock template. That's enough to satisfy a local run of fedora-review, but I expect the review service build won't work for a few more days. [0] bug 2224161 [1] https://bodhi.fedoraproject.org/updates/FEDORA-2023-dccb399c14
Nothing blocking. Approved. = Review = - rpmlint checks return: blackbox-terminal.x86_64: W: no-manual-page-for-binary blackbox-terminal blackbox-terminal.x86_64: W: no-documentation blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-fullscreen-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-fullscreen-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-show-headerbar-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/com.raggesilver.BlackBox-show-headerbar-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/external-link-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/external-link-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/actions/settings-symbolic.svg /usr/share/blackbox/icons/hicolor/scalable/actions/settings-symbolic.svg blackbox-terminal.x86_64: W: files-duplicate /usr/share/icons/hicolor/scalable/apps/com.raggesilver.BlackBox.svg /usr/share/blackbox/icons/hicolor/scalable/apps/com.raggesilver.BlackBox.svg Maybe consider symlinking those svg files to cut down on install footprint a bit. Not a MUST. - package meets naming guidelines - package meets packaging guidelines - license (GPL-3.0-or-later AND (MIT OR Apache-2.0) AND MPL-2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (0a8b76666ac71a6dc9e05b8084e1c6c53cda880ad1f8f778d9d5de9a6644ad0d) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc <- Should README.md be in there? - Desktop file validated
The Pagure repository was created at https://src.fedoraproject.org/rpms/blackbox-terminal
> blackbox-terminal.x86_64: W: files-duplicate ... It looks like cause of this is the upstream meson config installs the icons twice into separate directories. I've opened a merge request upstream to fix it, and applied it as a patch in the package. https://gitlab.gnome.org/raggesilver/blackbox/-/merge_requests/126 > - nothing in %doc <- Should README.md be in there? I added README.md and CHANGELOG.md.
FEDORA-2023-828d2a8c2d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-828d2a8c2d
FEDORA-2023-828d2a8c2d has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-e785787322 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e785787322
FEDORA-2023-e785787322 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-e9e4c3992c has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e9e4c3992c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e9e4c3992c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-e9e4c3992c has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.