Spec URL: https://deamn.fedorapeople.org/ipcgull.spec SRPM URL: https://deamn.fedorapeople.org/ipcgull-0.1-0.fc39.src.rpm Description: Ipcgull is a C++ IPC library that takes advantage of modern C++17 features to provide a simple interface for developers to handle IPC. Currently, Ipcgull only supports a D-Bus backend (via GDBus), but this is abstracted by the library and can theoretically be replaced. However, that is out of scope for this project. This project was originally designed solely for use in LogiOps. Fedora Account System Username: deamn
1. Why debug_package %{nil} ? 2. Release: 0%{?dist} must be Release: 1%{?dist} 3. Need to change License: GPLv3 to License: GPL-3.0-or-later 4. For devel package need to change Requires: %{name} = %{version}-%{release} to Requires: %{name}%{?_isa} = %{version}-%{release} 5. All at %prep section can be changed to %autosetup 6. install -D -m 755 must be changed to install -D -pm 755 7. Remove %ldconfig_scriptlets
Please find the spec and srpm files updated like your review: Spec URL: https://deamn.fedorapeople.org/ipcgull.spec SRPM URL: https://deamn.fedorapeople.org/ipcgull-0.1-1.fc39.src.rpm
Created attachment 1976690 [details] The .spec file difference from Copr build 6189364 to 6189852
Strange Epoch: 0 and %{cmake} -DPROJECT_EPOCH=%{epoch} Can you remove this epoch using and set -DPROJECT_EPOCH=0 ? Seems that for build not need really epoch number from rpm package.
(In reply to Vasiliy Glazov from comment #4) > Strange Epoch: 0 > and %{cmake} -DPROJECT_EPOCH=%{epoch} > > Can you remove this epoch using and set -DPROJECT_EPOCH=0 ? > > Seems that for build not need really epoch number from rpm package. I replaced by a global project variable. The links still the same but the files are updated accordingly to your suggestion.
My fedora-review fall in exception but all seems good now. Package Approved. Don't forget to close this ticket after adding package to the repos.
The Pagure repository was created at https://src.fedoraproject.org/rpms/ipcgull