Bug 2224327 - Review Request: rust-human_format - Converts a number to/from a human readable string
Summary: Review Request: rust-human_format - Converts a number to/from a human readabl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-20 12:28 UTC by blinxen
Modified: 2023-07-21 07:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-21 07:50:59 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description blinxen 2023-07-20 12:28:38 UTC
Spec URL: https://blinxen.fedorapeople.org/rust-human_format/rust-human_format.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-human_format/rust-human_format-1.0.3-1.fc39.src.rpm

Description:
Rust Port of human-format from node, formatting numbers for us, while
the machines are still at bay.

Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-07-20 12:59:22 UTC
Error HTTP Error 403: Forbidden downloading https://blinxen.fedorapeople.org/rust-human_format/rust-human_format-1.0.3-1.fc39.src.rpm

Comment 2 blinxen 2023-07-20 13:04:36 UTC
Should be fixed now

Comment 3 Fabio Valentini 2023-07-20 13:28:28 UTC
Looks good to me, with one minor issue (noted below).

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (tests are disabled due to missing dependency)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

If you disable tests by switching "%bcond_without check" to "%bcond_with check", then removing the test dependency is redundant. If "check" bcond is off, no test dependencies will be generated by %cargo_generate_buildrequires.

It also looks like the tests are pretty weird and use the "galvanic" stuff for things that can be done without extra dependencies too ... but oh well.

Comment 4 Fedora Admin user for bugzilla script actions 2023-07-21 07:24:22 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-human_format

Comment 5 Fedora Update System 2023-07-21 07:47:25 UTC
FEDORA-2023-351340c6af has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-351340c6af

Comment 6 Fedora Update System 2023-07-21 07:50:59 UTC
FEDORA-2023-351340c6af has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.