Bug 2224501 - Review Request: libsc - The "sc" auxiliary library
Summary: Review Request: libsc - The "sc" auxiliary library
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2023-07-21 07:26 UTC by Felix Wang
Modified: 2024-02-08 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-08 00:45:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Felix Wang 2023-07-21 07:26:28 UTC
Spec URL: https://topazus.fedorapeople.org/rpms/libsc.spec
SRPM URL: https://topazus.fedorapeople.org/rpms/libsc-2.8.5-1.20230420git83bd019.fc39.src.rpm
Description:
The sc library provides functions and data types that can be useful in
scientific computing. It is part of the p4est project, which uses it
extensively. Consequently, it is also a dependency of all projects that use
p4est. Some of the more important features are the following:

* The build system is based on the GNU autotools. Several macro files reside in
the config/ subdirectory. These are used in sc but also available to other
projects for convenience. It is possible to nest packages this way.
* The library provides MPI wrappers in case it is configured without MPI. They
implement initialize/finalize and collective calls as noops, which means that
these do not have to be protected with the #ifdef SC_MPI construct in the code.
* The library provides a logging framework that can be adapted by other packages.
Multiple log levels are available, as well as options to output on just one or
all MPI processes.
* The library provides a set of data containers, such as dynamically resizable
arrays.

Fedora Account System Username: topazus

Comment 1 Felix Wang 2023-07-21 07:27:05 UTC
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=103673673

Comment 2 Michel Lind 2023-07-27 20:21:40 UTC
Felix: the files in libb64 are CC-PDDC but the license comment says MIT, please fix.

Some files are actually BSD-2-Clause (including files in iniparser despite the license file claiming it is MIT; I re-checked licensecheck's output and some files definitely have BSD headers)

BSD 2-Clause License
--------------------
libsc-83bd019fc9f029a9c15a3ae823e6d7d20e6e0340/iniparser/inistring.c
libsc-83bd019fc9f029a9c15a3ae823e6d7d20e6e0340/iniparser/inistring.h
libsc-83bd019fc9f029a9c15a3ae823e6d7d20e6e0340/src/sc3_mpi_types.h
libsc-83bd019fc9f029a9c15a3ae823e6d7d20e6e0340/src/sc_uint128.c
libsc-83bd019fc9f029a9c15a3ae823e6d7d20e6e0340/src/sc_uint128.h
libsc-83bd019fc9f029a9c15a3ae823e6d7d20e6e0340/test/test_helpers.c
libsc-83bd019fc9f029a9c15a3ae823e6d7d20e6e0340/test/test_version.c


LGPL-2.0-or-later should be LGPL-2.1-or-later

Please declare the bundling of libb4 and iniparser, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling and ship their LICENSE texts as well (renaming if necessary to avoid conflicts)

Comment 3 Package Review 2024-02-08 00:45:36 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.