Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gofiber-fiber-2.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gofiber-fiber-2-2.48.0-1.fc38.src.rpm Description: ⚡️ Express inspired web framework written in Go. Fedora Account System Username: eclipseo
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=103704146
I will take this review.
I know a full review isn't necessary, but I'm still unfamiliar enough with the Go ecosystem that it makes me feel better to have fedora-review back me up. Also, this spec file wins an award for creative use of Unicode. :-) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ====== - The licensing breakdown is not documented in the spec file - The BSD-3-Clause license seems to apply to vendored dependencies (gopsutil and schema). Can those be unbundled? If not, shouldn't the spec file contain "Provides: bundled(...)"? Note that other vendored dependencies have the same license as this package (MIT): go-ole and wmi. - Can anything be done about the duplicated files (see the rpmlint output), or is that normal for golang packages? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "MIT License", "BSD 3-Clause License". 412 files have unknown license. Detailed output of licensecheck in /home/jamesjer/2224616-golang- github-gofiber-fiber-2/licensecheck.txt [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 281464 bytes in 50 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-gofiber-fiber-2-devel-2.48.0-1.fc39.noarch.rpm golang-github-gofiber-fiber-2-2.48.0-1.fc39.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpm2w4hdon')] checks: 31, packages: 2 golang-github-gofiber-fiber-2.spec: W: no-%build-section golang-github-gofiber-fiber-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/gofiber/fiber/v2/.goipath golang-github-gofiber-fiber-2-devel.noarch: E: files-duplicated-waste 283462 golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/utils/README.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/README.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/app.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/app.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/client.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/client.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/constants.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/constants.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/ctx.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/ctx.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/fiber.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/fiber.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/log.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/log.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/adaptor.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/adaptor.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/basicauth.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/basicauth.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/cache.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/cache.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/compress.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/compress.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/cors.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/cors.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/csrf.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/csrf.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/earlydata.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/earlydata.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/encryptcookie.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/encryptcookie.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/envvar.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/envvar.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/etag.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/etag.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/expvar.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/expvar.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/favicon.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/favicon.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/filesystem.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/filesystem.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/helmet.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/helmet.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/idempotency.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/idempotency.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/keyauth.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/keyauth.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/limiter.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/limiter.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/logger.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/logger.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/monitor.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/monitor.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/pprof.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/pprof.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/proxy.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/proxy.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/recover.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/recover.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/redirect.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/redirect.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/requestid.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/requestid.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/rewrite.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/rewrite.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/session.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/session.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/skip.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/skip.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/timeout.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/timeout.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/extra/benchmarks.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/extra/benchmarks.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/extra/faq.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/extra/faq.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/error-handling.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/error-handling.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/faster-fiber.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/faster-fiber.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/grouping.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/grouping.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/hooks.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/hooks.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/routing.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/routing.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/templates.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/templates.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/validation.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/validation.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/intro.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/intro.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/partials/routing/handler.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/partials/routing/handler.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_arm64.go /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_dragonfly_amd64.go:/usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_amd64.go golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_arm.go /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_386.go golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/process/process_darwin_amd64.go /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/process/process_darwin_386.go ================ 2 packages and 0 specfiles checked; 1 errors, 51 warnings, 1 badness; has taken 0.2 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-gofiber-fiber-2-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/gofiber/fiber/v2/.goipath golang-github-gofiber-fiber-2-devel.noarch: E: files-duplicated-waste 283462 golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/utils/README.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/README.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/app.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/app.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/client.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/client.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/constants.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/constants.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/ctx.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/ctx.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/fiber.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/fiber.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/log.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/log.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/adaptor.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/adaptor.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/basicauth.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/basicauth.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/cache.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/cache.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/compress.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/compress.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/cors.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/cors.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/csrf.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/csrf.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/earlydata.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/earlydata.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/encryptcookie.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/encryptcookie.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/envvar.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/envvar.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/etag.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/etag.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/expvar.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/expvar.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/favicon.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/favicon.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/filesystem.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/filesystem.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/helmet.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/helmet.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/idempotency.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/idempotency.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/keyauth.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/keyauth.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/limiter.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/limiter.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/logger.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/logger.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/monitor.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/monitor.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/pprof.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/pprof.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/proxy.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/proxy.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/recover.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/recover.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/redirect.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/redirect.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/requestid.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/requestid.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/rewrite.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/rewrite.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/session.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/session.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/skip.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/skip.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/api/middleware/timeout.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/api/middleware/timeout.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/extra/benchmarks.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/extra/benchmarks.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/extra/faq.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/extra/faq.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/error-handling.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/error-handling.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/faster-fiber.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/faster-fiber.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/grouping.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/grouping.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/hooks.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/hooks.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/routing.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/routing.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/templates.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/templates.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/guide/validation.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/guide/validation.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/intro.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/intro.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/docs/partials/routing/handler.md /usr/share/doc/golang-github-gofiber-fiber-2-devel/docs/partials/routing/handler.md golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_arm64.go /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_dragonfly_amd64.go:/usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_amd64.go golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_arm.go /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/cpu/cpu_freebsd_386.go golang-github-gofiber-fiber-2-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/process/process_darwin_amd64.go /usr/share/gocode/src/github.com/gofiber/fiber/v2/internal/gopsutil/process/process_darwin_386.go 1 packages and 0 specfiles checked; 1 errors, 50 warnings, 1 badness; has taken 0.1 s Source checksums ---------------- https://github.com/gofiber/fiber/archive/v2.48.0/fiber-2.48.0.tar.gz : CHECKSUM(SHA256) this package : 9caa6987268f269ee9c7d8309083140d44f8b452b0c52b84e74c7b698fc7a227 CHECKSUM(SHA256) upstream package : 9caa6987268f269ee9c7d8309083140d44f8b452b0c52b84e74c7b698fc7a227 Requires -------- golang-github-gofiber-fiber-2-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/google/uuid) golang(github.com/mattn/go-colorable) golang(github.com/mattn/go-isatty) golang(github.com/mattn/go-runewidth) golang(github.com/tinylib/msgp/msgp) golang(github.com/valyala/bytebufferpool) golang(github.com/valyala/fasthttp) golang(github.com/valyala/fasthttp/expvarhandler) golang(github.com/valyala/fasthttp/fasthttpadaptor) golang(github.com/valyala/fasthttp/reuseport) golang(golang.org/x/sys/unix) Provides -------- golang-github-gofiber-fiber-2-devel: golang(github.com/gofiber/fiber/v2) golang(github.com/gofiber/fiber/v2/internal/go-ole) golang(github.com/gofiber/fiber/v2/internal/go-ole/oleutil) golang(github.com/gofiber/fiber/v2/internal/gopsutil/common) golang(github.com/gofiber/fiber/v2/internal/gopsutil/cpu) golang(github.com/gofiber/fiber/v2/internal/gopsutil/load) golang(github.com/gofiber/fiber/v2/internal/gopsutil/mem) golang(github.com/gofiber/fiber/v2/internal/gopsutil/net) golang(github.com/gofiber/fiber/v2/internal/gopsutil/process) golang(github.com/gofiber/fiber/v2/internal/memory) golang(github.com/gofiber/fiber/v2/internal/schema) golang(github.com/gofiber/fiber/v2/internal/storage/memory) golang(github.com/gofiber/fiber/v2/internal/template/html) golang(github.com/gofiber/fiber/v2/internal/template/utils) golang(github.com/gofiber/fiber/v2/internal/tlstest) golang(github.com/gofiber/fiber/v2/log) golang(github.com/gofiber/fiber/v2/middleware/adaptor) golang(github.com/gofiber/fiber/v2/middleware/basicauth) golang(github.com/gofiber/fiber/v2/middleware/cache) golang(github.com/gofiber/fiber/v2/middleware/compress) golang(github.com/gofiber/fiber/v2/middleware/cors) golang(github.com/gofiber/fiber/v2/middleware/csrf) golang(github.com/gofiber/fiber/v2/middleware/earlydata) golang(github.com/gofiber/fiber/v2/middleware/encryptcookie) golang(github.com/gofiber/fiber/v2/middleware/envvar) golang(github.com/gofiber/fiber/v2/middleware/etag) golang(github.com/gofiber/fiber/v2/middleware/expvar) golang(github.com/gofiber/fiber/v2/middleware/favicon) golang(github.com/gofiber/fiber/v2/middleware/filesystem) golang(github.com/gofiber/fiber/v2/middleware/helmet) golang(github.com/gofiber/fiber/v2/middleware/idempotency) golang(github.com/gofiber/fiber/v2/middleware/keyauth) golang(github.com/gofiber/fiber/v2/middleware/limiter) golang(github.com/gofiber/fiber/v2/middleware/logger) golang(github.com/gofiber/fiber/v2/middleware/monitor) golang(github.com/gofiber/fiber/v2/middleware/pprof) golang(github.com/gofiber/fiber/v2/middleware/proxy) golang(github.com/gofiber/fiber/v2/middleware/recover) golang(github.com/gofiber/fiber/v2/middleware/redirect) golang(github.com/gofiber/fiber/v2/middleware/requestid) golang(github.com/gofiber/fiber/v2/middleware/rewrite) golang(github.com/gofiber/fiber/v2/middleware/session) golang(github.com/gofiber/fiber/v2/middleware/skip) golang(github.com/gofiber/fiber/v2/middleware/timeout) golang(github.com/gofiber/fiber/v2/utils) golang-github-gofiber-fiber-2-devel golang-ipath(github.com/gofiber/fiber/v2) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2224616 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: fonts, Java, SugarActivity, R, Perl, Ruby, Ocaml, Python, PHP, C/C++, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> - Can anything be done about the duplicated files (see the rpmlint output), or is that normal for golang packages? It's how the macros work. I'll look if we can change that somehow. > - The BSD-3-Clause license seems to apply to vendored dependencies (gopsutil and schema). Can those be unbundled? If not, shouldn't the spec file contain "Provides: bundled(...)"? Note that other vendored dependencies have the same license as this package (MIT): go-ole and wmi. Yes it seems they have sneakily vendored stuff: - gopsutil, for which go-ole and wmi are deps. Fortunately, we have github.com/shirou/gopsutil in Fedora. - schema, which comes from github.com/gorilla/schema. I can't unbundle it because they made modifications to the code, if I try, tests don't pass. So we'll do: # MIT: main package # BSD-3-Clause: internal/schema taken from github.com/gorilla/schema License: MIT amd BSD-3-Clause and: rm -rfv internal/go-ole internal/gopsutil internal/wmi sed -i "s|github.com/gofiber/fiber/v2/internal/gopsutil|github.com/shirou/gopsutil|" $(find . -iname "*.go" -type f)
Ok not possible, they modified gopsutil too. But I can remove the Windows deps though.
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gofiber-fiber-2.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-gofiber-fiber-2-2.48.0-1.fc38.src.rpm
Created attachment 1983409 [details] The .spec file difference from Copr build 6201253 to 6293667
Looks good to me. This package is APPROVED.
Thanks!
Thank you for the review, Jerry https://pagure.io/releng/fedora-scm-requests/issue/55675
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gofiber-fiber-2
FEDORA-2023-78ba5e9831 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-78ba5e9831
FEDORA-2023-da1c8652a5 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-da1c8652a5
FEDORA-2023-78ba5e9831 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-78ba5e9831 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-78ba5e9831 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-da1c8652a5 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-da1c8652a5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-da1c8652a5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-78ba5e9831 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-da1c8652a5 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.