Bug 2224754 - Review Request: rust-urid-derive - Procedural macros for urid
Summary: Review Request: rust-urid-derive - Procedural macros for urid
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/urid-derive
Whiteboard:
Depends On:
Blocks: 2224751 2224757
TreeView+ depends on / blocked
 
Reported: 2023-07-22 16:43 UTC by Davide Cavalca
Modified: 2023-08-09 02:31 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-23 03:54:11 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-07-22 16:43:43 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-urid-derive/rust-urid-derive.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-urid-derive/rust-urid-derive-0.1.1-1.fc39.src.rpm

Description:
Procedural macros for urid.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-22 16:43:46 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103747973

Comment 2 Fedora Review Service 2023-07-22 16:49:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6203855
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224754-rust-urid-derive/fedora-rawhide-x86_64/06203855-rust-urid-derive/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-07-22 21:35:19 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-07-23 03:15:56 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-urid-derive

Comment 5 Fedora Update System 2023-07-23 03:51:24 UTC
FEDORA-2023-3724df7a6d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3724df7a6d

Comment 6 Fedora Update System 2023-07-23 03:54:11 UTC
FEDORA-2023-3724df7a6d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-07-31 05:11:56 UTC
FEDORA-2023-3799773959 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3799773959

Comment 8 Fedora Update System 2023-07-31 16:35:54 UTC
FEDORA-2023-844b251793 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-844b251793

Comment 9 Fedora Update System 2023-08-01 01:40:57 UTC
FEDORA-2023-3799773959 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3799773959 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3799773959

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-08-01 01:51:03 UTC
FEDORA-2023-844b251793 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-844b251793 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-844b251793

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-08-09 01:30:17 UTC
FEDORA-2023-3799773959 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-08-09 02:31:48 UTC
FEDORA-2023-844b251793 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.