Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-pywayland/fedora-rawhide-x86_64/06204253-python-pywayland/python-pywayland.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-pywayland/fedora-rawhide-x86_64/06204253-python-pywayland/python-pywayland-0.4.15-1.fc39.src.rpm Description: PyWayland provides a wrapper to the libwayland library using the CFFI library to provide access to the Wayland library calls and written in pure Python. Fedora Account System Username: frostyx
Copr build: https://copr.fedorainfracloud.org/coprs/build/6204262 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224780-python-pywayland/fedora-rawhide-x86_64/06204262-python-pywayland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-pywayland/fedora-rawhide-x86_64/06204306-python-pywayland/python-pywayland.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-pywayland/fedora-rawhide-x86_64/06204306-python-pywayland/python-pywayland-0.4.15-2.fc39.src.rpm
Created attachment 1977095 [details] The .spec file difference from Copr build 6204262 to 6204327
Copr build: https://copr.fedorainfracloud.org/coprs/build/6204327 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224780-python-pywayland/fedora-rawhide-x86_64/06204327-python-pywayland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please use SPDX license identifiers. In licensecheck.txt [1] two other licenses are identified. Please clarify and/or amend license tag. [1]: https://download.copr.fedorainfracloud.org/results/gui1ty/reviews/fedora-38-x86_64/06204451-python-pywayland/fedora-review/licensecheck.txt
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file copyright.cpython-311.opt-1.pyc is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text => Looks like a fluke. The copyright.py file carries the Apach-2.0 preamble. [!]: Development (unversioned) .so files in -devel subpackage, if present. => /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so I'm not very at home in the C/C++ world. But that file probably belongs elsewhere. [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. rpmlint: W: invalid-license Apache2 => See previous comment. [!]: %check is present and all tests pass. => Is there a reason for not running the tests? GUI needed or such? python3-pywayland.x86_64: W: no-documentation => Please include README.rst ===== MUST items ===== C/C++: [!]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0", "Apache License 2.0 [generated file]", "ISC License [generated file]", "NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell variant [generated file]". 158 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/python- pywayland/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-pywayland-0.4.15-2.fc38.x86_64.rpm python-pywayland-debugsource-0.4.15-2.fc38.x86_64.rpm python-pywayland-0.4.15-2.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpq2leo4op')] checks: 31, packages: 3 python3-pywayland.x86_64: W: no-manual-page-for-binary pywayland-scanner python3-pywayland.x86_64: W: no-documentation python-pywayland.src: W: invalid-license Apache2 python-pywayland-debugsource.x86_64: W: invalid-license Apache2 python3-pywayland.x86_64: W: invalid-license Apache2 3 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so _Py_NoneStruct (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyObject_CallMethod (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyEval_RestoreThread (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so _Py_Dealloc (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyObject_Malloc (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyObject_Free (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyFloat_FromDouble (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyLong_FromLong (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyLong_FromVoidPtr (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyArg_UnpackTuple (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyErr_Occurred (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyImport_ImportModule (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyFloat_AsDouble (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so PyEval_SaveThread (/usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so) python3-pywayland.x86_64: W: no-manual-page-for-binary pywayland-scanner python3-pywayland.x86_64: W: no-documentation python-pywayland-debugsource.x86_64: W: invalid-license Apache2 python3-pywayland.x86_64: W: invalid-license Apache2 2 packages and 0 specfiles checked; 0 errors, 18 warnings, 0 badness; has taken 0.3 s Unversioned so-files -------------------- python3-pywayland: /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so
Thank you very much for the review. Updated. Spec URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-pywayland/fedora-rawhide-x86_64/06211785-python-pywayland/python-pywayland.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/frostyx/python-pywayland/fedora-rawhide-x86_64/06211785-python-pywayland/python-pywayland-0.4.15-3.fc39.src.rpm > [!]: Development (unversioned) .so files in -devel subpackage, if present. > > => /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so Same as RHBZ 2224781, this should be a false-positive.
Created attachment 1979171 [details] The .spec file difference from Copr build 6204327 to 6211855
Copr build: https://copr.fedorainfracloud.org/coprs/build/6211855 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224780-python-pywayland/fedora-rawhide-x86_64/06211855-python-pywayland/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> > [!]: Development (unversioned) .so files in -devel subpackage, if present. > > > > => /usr/lib64/python3.11/site-packages/pywayland/_ffi.abi3.so > > Same as RHBZ 2224781, this should be a false-positive. Yes it seems to be the Pythonian way. I meanwhile came across another Python package doing the same. Everything checks out now. Package is APPROVED!
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pywayland
FEDORA-2023-99566edeee has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-99566edeee
FEDORA-2023-99566edeee has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-99566edeee \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-99566edeee See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-99566edeee has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.