Bug 2224814 - Review Request: rust-drm-sys - Bindings to the Direct Rendering Manager API
Summary: Review Request: rust-drm-sys - Bindings to the Direct Rendering Manager API
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/drm-sys
Whiteboard:
Depends On:
Blocks: 2224807 2224815
TreeView+ depends on / blocked
 
Reported: 2023-07-23 05:07 UTC by Davide Cavalca
Modified: 2023-08-07 01:26 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-23 14:35:59 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-07-23 05:07:10 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-drm-sys/rust-drm-sys.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-drm-sys/rust-drm-sys-0.4.0-1.fc39.src.rpm

Description:
Bindings to the Direct Rendering Manager API.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-23 05:07:13 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103773866

Comment 2 Fedora Review Service 2023-07-23 05:13:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6205017
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224814-rust-drm-sys/fedora-rawhide-x86_64/06205017-rust-drm-sys/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-07-23 14:05:22 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-07-23 14:15:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-drm-sys

Comment 5 Fedora Update System 2023-07-23 14:35:45 UTC
FEDORA-2023-b4c3b25bcf has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b4c3b25bcf

Comment 6 Fedora Update System 2023-07-23 14:35:59 UTC
FEDORA-2023-b4c3b25bcf has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fabio Valentini 2023-07-25 13:23:17 UTC
This crate supports regenerating bindings at build-time with the "use_bindgen" feature, which should allow to build for ppc64le and s390x as well.
Have you tried unconditionally enabling the code wrapped in the "use_bindgen" feature (and making the bindgen dependency non-optional)?

Comment 8 Fedora Update System 2023-08-06 21:00:55 UTC
FEDORA-2023-c2d333f341 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2d333f341

Comment 9 Fedora Update System 2023-08-07 01:26:39 UTC
FEDORA-2023-c2d333f341 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.