Bug 2224958 - Review Request: rust-udev - Libudev bindings for Rust
Summary: Review Request: rust-udev - Libudev bindings for Rust
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2224807 2224961
TreeView+ depends on / blocked
 
Reported: 2023-07-24 04:46 UTC by Davide Cavalca
Modified: 2023-08-07 01:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-24 16:27:03 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-07-24 04:46:16 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-udev/rust-udev.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-udev/rust-udev-0.7.0-1.fc39.src.rpm

Description:
Libudev bindings for Rust.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-24 04:46:18 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103811352

Comment 2 Fabio Valentini 2023-07-24 12:47:01 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment from maintainability point of view:
Do you really need support for mio v0.6, v0.7, and v0.8, or would just supporting the latest version be enough?
Adding dependencies on old compat packages just for fun makes the dependency tree for those old versions bigger for no reason (and I'm trying to reduce the number of compat packages I'm maintaining).

Comment 3 Davide Cavalca 2023-07-24 15:16:05 UTC
> Do you really need support for mio v0.6, v0.7, and v0.8, or would just supporting the latest version be enough?

Good catch, just the last one should be fine. Will fix this on import, thanks!

Comment 4 Fedora Admin user for bugzilla script actions 2023-07-24 15:16:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-udev

Comment 5 Fedora Update System 2023-07-24 16:26:24 UTC
FEDORA-2023-42df084090 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-42df084090

Comment 6 Fedora Update System 2023-07-24 16:27:03 UTC
FEDORA-2023-42df084090 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-08-06 21:01:07 UTC
FEDORA-2023-c2d333f341 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2d333f341

Comment 8 Fedora Update System 2023-08-07 01:26:48 UTC
FEDORA-2023-c2d333f341 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.