Spec URL: https://topazus.fedorapeople.org/rpms/veccore.spec SRPM URL: https://topazus.fedorapeople.org/rpms/veccore-0.8.0-1.fc39.src.rpm Description: C++ Library for Portable SIMD Vectorization Fedora Account System Username: topazus
https://koji.fedoraproject.org/koji/taskinfo?taskID=103817857
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=103817857
Spec URL: https://topazus.fedorapeople.org/rpms/veccore.spec SRPM URL: https://topazus.fedorapeople.org/rpms/veccore-0.8.0-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6647966 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2225003-veccore/fedora-rawhide-x86_64/06647966-veccore/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[!]: Package complies to the Packaging Guidelines Missing Provides: *-static for header only library. > Packaging Header Only Libraries > "... must have a virtual Provide for the *-static package:" > > %package devel > Provides: foo-static = %{version}-%{release} > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries [!]: Latest version is packaged. The latest version is 0.8.1. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [?]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "BSD 3-Clause License". 119 files have unknown license. Detailed output of licensecheck in /home/jonny/tmp/2225003-veccore/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5965 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: veccore-devel-0.8.0-1.fc40.x86_64.rpm veccore-0.8.0-1.fc40.src.rpm ==================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpnmpbxnmb')] checks: 31, packages: 2 veccore-devel.x86_64: W: only-non-binary-in-usr-lib ===================================================== 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.6 s ==================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 veccore-devel.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://gitlab.cern.ch/VecGeom/VecCore/-/archive/v0.8.0/VecCore-v0.8.0.tar.bz2 : CHECKSUM(SHA256) this package : 39d98ea17b60e0387fe38e95898b9f97fc3b946c76a0919c17eb81380c8d5d26 CHECKSUM(SHA256) upstream package : 39d98ea17b60e0387fe38e95898b9f97fc3b946c76a0919c17eb81380c8d5d26 Requires -------- veccore-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) Provides -------- veccore-devel: cmake(VecCore) cmake(veccore) veccore-devel veccore-devel(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jonny/tmp/2225003-veccore/srpm/veccore.spec 2023-11-16 20:23:20.561754058 +0200 +++ /home/jonny/tmp/2225003-veccore/srpm-unpacked/veccore.spec 2023-07-24 03:00:00.000000000 +0300 @@ -14,4 +14,7 @@ Source0: %{forgesource} +# https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval +ExcludeArch: %{ix86} + BuildRequires: gcc-c++ BuildRequires: cmake @@ -50,4 +53,5 @@ %cmake \ -GNinja \ + -DCMAKE_BUILD_TYPE=Release \ -DBUILD_TESTING=ON \ Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2225003 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Python, Java, Perl, SugarActivity, Ocaml, R, fonts, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> [!]: Package complies to the Packaging Guidelines > > Missing Provides: *-static for header only library. Fixed. > [!]: Latest version is packaged. > > The latest version is 0.8.1. It seems that the upstream project of veccore is on GitLab and Github. The project on GitLab do not publish new tag or release of 0.8.1, while the project on Github do. So I switch the Source to its GitHub upstream. 1. https://gitlab.cern.ch/VecGeom/VecCore/-/tags 2. https://github.com/root-project/veccore/releases/tag/v0.8.1 updated: Spec URL: https://topazus.fedorapeople.org/rpms/veccore.spec SRPM URL: https://topazus.fedorapeople.org/rpms/veccore-0.8.1-1.fc40.src.rpm
Created attachment 1999914 [details] The .spec file difference from Copr build 6647966 to 6659829
Copr build: https://copr.fedorainfracloud.org/coprs/build/6659829 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2225003-veccore/fedora-rawhide-x86_64/06659829-veccore/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package approved!
The Pagure repository was created at https://src.fedoraproject.org/rpms/veccore
Thanks a lot for taking time to review the package.
FEDORA-2023-5a98a31c9b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a98a31c9b
FEDORA-2023-5a98a31c9b has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.