Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/blobby.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/blobby-0.6-0.1.a.src.rpm Description: Blobby Volley is one of the most popular freeware games. Blobby Volley 2 is the continuation of this lovely game.
I'll review it.
REVIEW: * sources match upstream (md5: fdef3e59f0870d890be8dffaccd773ca) * package meets all guidelines it should * correct build root: %{_tmppath}/%{name}-%{version}-%{release}- root-%(%{__id_u} -n) * package is licensed under a GPL license and license text is included in package * the latest version is being packaged * no shared libraries * no duplicates in %files * %clean is present * proper scriptlets * no need to any subpackages * rpmlint is silent * final provides and requires are sane !* desktop file: Category Application is deprecated and should be removed. https://www.redhat.com/archives/fedora-extras-list/2006-October/msg00723.html * BRs listed good * mock builds fine (fc6/x86_64) * all directories are owned well !* a lack of Requires: you should add hicolor-icon-theme dependency: https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html THINGS to do: - get rid of an Application category - add hicolor-icon-theme dependency
Thanks for the review. I've added the hicolor-icon-theme dependency, but I'm not sure about the Application category, since the example on the Packaging Guidelines page still has it : http://fedoraproject.org/wiki/Packaging/Guidelines#desktop I've posted on the packaging list for advice, I'll let you know the results.
(In reply to comment #3) > Thanks for the review. I've added the hicolor-icon-theme dependency, but I'm not > sure about the Application category, since the example on the Packaging > Guidelines page still has it : > http://fedoraproject.org/wiki/Packaging/Guidelines#desktop So that should be fixed. There's desktop-file-utils-0.12 in fc7 and its desktop-file-validate shows the following error: [ecik@ecik /download]$ desktop-file-validate /usr/share/applications/fedora- blobby.desktop /usr/share/applications/fedora-blobby.desktop: warning: The 'Application' category is not defined by the desktop entry specification. Please use one of "AudioVideo", "Audio", "Video", "Development", "Education", "Game", "Graphics", "Network", "Office", "Settings", "System", "Utility" instead
OK then, thanks. * Sun Jan 14 2007 Aurelien Bompard <abompard> 0.6-0.2.a - add dependency on hicolor-icon-theme (#222547) - removed the "Application" category from the desktop file http://gauret.free.fr/fichiers/rpms/fedora/blobby.spec http://gauret.free.fr/fichiers/rpms/fedora/blobby-0.6-0.2.a.src.rpm
Approved.
Just something I caught at the last minute: * Sun Jan 14 2007 Aurelien Bompard <abompard> 0.6-0.3.a - patch it to obey RPM_OPT_FLAGS http://gauret.free.fr/fichiers/rpms/fedora/blobby.spec http://gauret.free.fr/fichiers/rpms/fedora/blobby-0.6-0.3.a.src.rpm Please tell if you still approve it with this change.
Please don't use autotool when possible. It seems that the flag "-Os" is used only at one point in configure, so making a patch for configure, not for configure.in should be easy.
Sure, I don't mind, but why ? What's the problem with it ? Anyway, I've patched configure instead : http://gauret.free.fr/fichiers/rpms/fedora/blobby.spec http://gauret.free.fr/fichiers/rpms/fedora/blobby-0.6-0.4.a.src.rpm
(In reply to comment #9) > Sure, I don't mind, but why ? What's the problem with it ? Well, * A weak reason is just "please don't use which is not needed actually". * Another reason is that using autotool easily may generate files which upstream (or someone else) may not desire, especially when the version of autotool differ between which upstream used and which you used. This is once discussed when autotools are removed from minimum buildroot, starting from http://www.redhat.com/archives/fedora-maintainers/2006-September/msg00146.html
Fine, thanks for this clear reply.
Package is still approved, of course.
Imported and built, thanks !