Bug 2225471 - 389-ds-base FTBFS with rust-1.71.0
Summary: 389-ds-base FTBFS with rust-1.71.0
Keywords:
Status: VERIFIED
Alias: None
Deadline: 2023-08-14
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: rust
Version: CentOS Stream
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Josh Stone
QA Contact: Jesus Checa
URL:
Whiteboard:
Depends On:
Blocks: 2227084
TreeView+ depends on / blocked
 
Reported: 2023-07-25 11:39 UTC by Tuomo Soini
Modified: 2023-07-31 11:41 UTC (History)
3 users (show)

Fixed In Version: rust-1.71.0-2.el9
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 2227084 (view as bug list)
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github rust-lang rust issues 112489 0 None closed Confusing new warning suspicious_double_ref_op in beta 1.71.0 2023-07-25 15:55:47 UTC
Github rust-lang rust pull 112517 0 None Merged `suspicious_double_ref_op`: don't lint on `.borrow()` 2023-07-25 15:55:47 UTC
Red Hat Issue Tracker RHELPLAN-163302 0 None None None 2023-07-25 11:40:09 UTC

Description Tuomo Soini 2023-07-25 11:39:39 UTC
Description of problem:

389-ds-base-2.3.4-2.el9 and 2.3.4-3.el9 both FTBFS with rust-1.71.0.

error: using `.borrow()` on a double reference, which returns `&concread::cowcell::CowCellReadTxn<CacheStats>` instead of borrowing the inner t
ype
  --> librslapd/src/cache.rs:60:28
   |
60 |     let stats = stat_rguard.borrow();
   |                            ^^^^^^^^^
   |
note: the lint level is defined here
  --> librslapd/src/lib.rs:1:9
   |
1  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(suspicious_double_ref_op)]` implied by `#[deny(warnings)]`
error: could not compile `librslapd` (lib) due to previous error

This is rust issue https://github.com/rust-lang/rust/issues/112489

Comment 1 Josh Stone 2023-07-25 15:55:48 UTC
I do not recommend deny(warnings) in production builds, since we rebase frequently and there may always be new warnings -- whether or not they are false positives.

Still, I can see about backporting the upstream fix for this.


Note You need to log in before you can comment on or make changes to this bug.