criu failed to build from source in Fedora rawhide/f39 https://koji.fedoraproject.org/koji/taskinfo?taskID=103565518 For details on the mass rebuild see: https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild Please fix criu at your earliest convenience and set the bug's status to ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks, criu will be orphaned. Before branching of Fedora 40, criu will be retired, if it still fails to build. For more details on the FTBFS policy, please visit: https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
Created attachment 1977710 [details] build.log file build.log too big, will only attach last 32768 bytes
Created attachment 1977711 [details] root.log file root.log too big, will only attach last 32768 bytes
Created attachment 1977712 [details] state.log
Failure is specific to s390x: In file included from compel/include/uapi/compel/asm/infect-types.h:7, from compel/arch/s390/src/lib/infect.c:12: compel/arch/s390/src/lib/infect.c: In function 'rewind_psw': compel/arch/s390/src/lib/infect.c:157:29: error: 'UL' undeclared (first use in this function) 157 | mask = (psw->mask & PSW_MASK_EA) ? -1UL : (psw->mask & PSW_MASK_BA) ? (1UL << 31) - 1 : (1UL << 24) - 1; | ^~~~~~~~~~~ compel/arch/s390/src/lib/infect.c:157:29: note: each undeclared identifier is reported only once for each function it appears in compel/arch/s390/src/lib/infect.c: In function 'get_ri_cb': compel/arch/s390/src/lib/infect.c:272:25: error: 'UL' undeclared (first use in this function) 272 | if (psw->mask & PSW_MASK_RI) | ^~~~~~~~~~~ compel/arch/s390/src/lib/infect.c: In function 's390_disable_ri_bit': compel/arch/s390/src/lib/infect.c:289:23: error: 'UL' undeclared (first use in this function) 289 | psw->mask &= ~PSW_MASK_RI; | ^~~~~~~~~~~ compel/arch/s390/src/lib/infect.c: In function 'arch_can_dump_task': compel/arch/s390/src/lib/infect.c:523:25: error: 'UL' undeclared (first use in this function) 523 | if (psw->mask & PSW_MASK_RI) { | ^~~~~~~~~~~
This is also happening only with the 6.5~rc kernel-headers in rawhide; an F38 scratch build with 6.4 kernel-headers succeeds on s390x.
likely caused by https://github.com/torvalds/linux/commit/b8af5999779d1225c82fcc960223625b279f5f0d
Right. Just also tracked it down to that commit. Thanks.
Agreed, and specifically it comes from the introduction of the use of `_AC` without #include <linux/const.h>
Created an upstream PR: https://github.com/checkpoint-restore/criu/pull/2232
Can we get the missing #include <linux/const.h> added to the kernel header itself?
I reached out to the original authors.
Builds again with the patch from Yaakov, thanks.