Spec URL: http://tux.u-strasbg.fr/~chit/RPMS/dolphin.spec SRPM URL: http://tux.u-strasbg.fr/~chit/RPMS/dolphin-0.8.1-1.src.rpm Description: Dolphin focuses on being only a file manager. This approach allows to optimize the user interface for the task of file management.
Got rpmlint warnings I: dolphin checking W: dolphin dangling-relative-symlink /usr/share/doc/HTML/en/dolphin/common ../common The relative symbolic link points nowhere. /tmp/dolphin-0.8.1-1.fc7.i386.rpm.26367/usr/share/applications/dolphin.desktop: warning: file contains key "DocPath", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-" Both warnings can be ignored for KDE package.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint is NOT silent for RPMS. + source match upstream. 62f526d93df2fe255d04625cbc670000 dolphin-0.8.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code Not contents. + no static libraries present. + no .pc files present. + no -devel subpackage exists. + no .la files. + no translations are available for installation. + Dose owns the directories it creates. + no duplicates in %files. + icon cache scriptlets used. + Desktop file handled correctly. + file permissions are appropriate. + GUI app APPROVED. Any reason behind not installing translation files?
Thanks for the review. I'll be uploading it once I'm back from holidays. http://fedoraproject.org/wiki/Vacation (In reply to comment #2) > APPROVED. > > Any reason behind not installing translation files? > What do you mean? In the spec file, I have already stated: ## File lists # locale's %find_lang %{name} || touch %{name}.lang # HTML (1.0)
(In reply to comment #3) > Thanks for the review. I'll be uploading it once I'm back from holidays. > http://fedoraproject.org/wiki/Vacation > > (In reply to comment #2) > > APPROVED. > > > > Any reason behind not installing translation files? > > > > What do you mean? > > In the spec file, I have already stated: > ## File lists > # locale's > %find_lang %{name} || touch %{name}.lang > # HTML (1.0) > I mean i saw following line in SPEC %{__rm} -f %{buildroot}%{_datadir}/locale/%{name}/LC_MESSAGES/%{name}.mo
Because that was an incomplete german locale, whereas my dolphin package is already shipping a complete german locale.
Package Change Request ====================== Package Name: piklab Updated Fedora Owners: cgoorah.au, johan
please discard comment #6 Package Change Request ====================== Package Name: dolphin Updated Fedora Owners: cgoorah.au, johan
Package Change Request ====================== Package Name: dolphin [Removed Branches: FC-6 FC-7 devel ] [Removed Fedora Owners: cgoorah.au ] Reason: d3lphin will obsolete dolphin.
Any reason you can't use the package end of life procedure? http://fedoraproject.org/wiki/PackageMaintainers/PackageEndOfLife I don't think we ever want to remove cvs branches if possible, so people can go back and get history on what was available.
done.