Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/06216851-python-lark/python-lark.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/06216851-python-lark/python-lark-1.1.7-1.fc39.src.rpm Description: Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity. Lark can parse all context-free languages. To put it simply, it means that it is capable of parsing almost any programming language out there, and to some degree most natural languages too. Fedora Account System Username: thrnciar
Copr build: https://copr.fedorainfracloud.org/coprs/build/6216902 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227008-python-lark/fedora-rawhide-x86_64/06216902-python-lark/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is a new upstream of https://src.fedoraproject.org/rpms/python-lark-parser We should probably Obsolete the old one and make sure the dependents are updated: $ repoquery -q --repo=rawhide{,-source} --whatrequires 'python3dist(lark-parser)' --whatrequires 'python3.12dist(lark-parser)' --whatrequires 'python3.11dist(lark-parser)' fedora-license-data-0:1.26-1.fc39.src license-validate-0:19-2.fc39.noarch license-validate-0:19-2.fc39.src python-hypothesmith-0:0.2.0-9.fc39.src python3-hypothesis+lark-0:6.62.1-4.fc39.noarch python3-hypothesmith-0:0.2.0-9.fc39.noarch
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/06219704-python-lark/python-lark.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/06219704-python-lark/python-lark-1.1.7-1.fc39.src.rpm Description: Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity. Lark can parse all context-free languages. To put it simply, it means that it is capable of parsing almost any programming language out there, and to some degree most natural languages too. Fedora Account System Username: thrnciar
Copr build: https://copr.fedorainfracloud.org/coprs/build/6219786 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227008-python-lark/fedora-rawhide-x86_64/06219786-python-lark/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/06219704-python-lark/python-lark.spec This is 404, the file is called python-lark-parser.spec
Ooops, correct links. Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-lark/fedora-rawhide-x86_64/06219931-python-lark/python-lark.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-lark/fedora-rawhide-x86_64/06219931-python-lark/python-lark-1.1.7-1.fc39.src.rpm Description: Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity. Lark can parse all context-free languages. To put it simply, it means that it is capable of parsing almost any programming language out there, and to some degree most natural languages too. Fedora Account System Username: thrnciar
Copr build: https://copr.fedorainfracloud.org/coprs/build/6219942 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227008-python-lark/fedora-rawhide-x86_64/06219942-python-lark/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for bringing this to Fedora. I was looking into packaging it myself as a dependency for another package I intent on bringing to Fedora. I was wondering about the name. On PyPI the package is called `lark-parser`[1], which links to `lark` on GitHub[2], which is URL mentioned in the spec. In line with PyPI parity[3], shouldn't the package be named `python-lark-parser`? [1] https://pypi.org/project/lark-parser/ [2] https://github.com/lark-parser/lark [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming
This is actually https://pypi.org/project/lark/ on pypi.
> License: MIT licensecheck from FedoraReview actually also found: *No copyright* Mozilla Public License 2.0 ----------------------------------------- lark-1.1.7/lark/tools/standalone.py GNU General Public License v2.0 or later ---------------------------------------- lark-1.1.7/lark/__pyinstaller/hook-lark.py Both of those files are shipped in the resulting package and hence the License field should contain the extra licenses (+there should be a licensing breakdown comment). python3-lark.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lark/README.md python3-lark.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lark/examples/calc.py python3-lark.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lark/examples/fruitflies.py python3-lark.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lark/examples/indented_tree.py python3-lark.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lark/examples/json_parser.py python3-lark.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lark/examples/lark_grammar.py python3-lark.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-lark/examples/turtle_dsl.py Please fix those in %prep, e.g. via sed.
Could you please also consider updating the description to match the current upstream version? E.g. they don't list "Python 2 & 3 compatible" as a feature but instead, they list for example "Type annotations"
(In reply to Miro Hrončok from comment #9) > This is actually https://pypi.org/project/lark/ on pypi. Oh, I see. But it's confusing that there's also lark-parser on PyPI which links to the same GitHub project as its homepage. Maybe lark-parser needs to be removed or at least amended, making it clear it's now called just 'lark'. Anyway, looking forward to the package.
Spec URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-lark/fedora-rawhide-x86_64/06229933-python-lark/python-lark.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/thrnciar/python-lark/fedora-rawhide-x86_64/06229933-python-lark/python-lark-1.1.7-1.fc39.src.rpm Description: Lark is a parsing toolkit for Python, built with a focus on ergonomics, performance and modularity. Lark can parse all context-free languages. To put it simply, it means that it is capable of parsing almost any programming language out there, and to some degree most natural languages too. Fedora Account System Username: thrnciar
Created attachment 1981117 [details] The .spec file difference from Copr build 6219942 to 6229940
Copr build: https://copr.fedorainfracloud.org/coprs/build/6229940 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227008-python-lark/fedora-rawhide-x86_64/06229940-python-lark/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Package APPROVED. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License", "GNU General Public License v2.0 or later", "*No copyright* Mozilla Public License 2.0". 104 files have unknown license. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.11/site- packages/lark(python3-lark-parser), /usr/lib/python3.11/site- packages/lark/__pycache__(python3-lark-parser), /usr/lib/python3.11/site-packages/lark/__pyinstaller(python3-lark- parser), /usr/lib/python3.11/site- packages/lark/__pyinstaller/__pycache__(python3-lark-parser), /usr/lib/python3.11/site-packages/lark/grammars(python3-lark-parser), /usr/lib/python3.11/site-packages/lark/parsers(python3-lark-parser), /usr/lib/python3.11/site- packages/lark/parsers/__pycache__(python3-lark-parser), /usr/lib/python3.11/site-packages/lark/tools(python3-lark-parser), /usr/lib/python3.11/site-packages/lark/tools/__pycache__(python3-lark- parser) This is OK, the package Obsoletes python3-lark-parser. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 112836 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-lark-1.1.7-1.fc38.noarch.rpm python-lark-1.1.7-1.fc38.src.rpm ============================================= rpmlint session starts ============================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmps3z0v8rz')] checks: 31, packages: 2 python3-lark.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/lark_parser-1.1.7.dist-info/INSTALLER /usr/lib/python3.11/site-packages/lark-1.1.7.dist-info/INSTALLER ============== 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.8 s ============= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 python3-lark.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/lark_parser-1.1.7.dist-info/INSTALLER /usr/lib/python3.11/site-packages/lark-1.1.7.dist-info/INSTALLER 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/l/lark/lark-1.1.7.tar.gz : CHECKSUM(SHA256) this package : be7437bf1f37ab08b355f29ff2571d77d777113d0a8c4352b0c513dced6c5a1e CHECKSUM(SHA256) upstream package : be7437bf1f37ab08b355f29ff2571d77d777113d0a8c4352b0c513dced6c5a1e Requires -------- python3-lark (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-lark: python-lark python-lark-parser python3-lark python3-lark-parser python3.12-lark python3.12-lark-parser python3.12dist(lark) python3.12dist(lark-parser) python3dist(lark) python3dist(lark-parser) Generated by fedora-review 0.7.0 (fed5495) last change: 2019-03-17 Command line :try-fedora-review -b 2227008 -m fedora-38-x86_64 Buildroot used: fedora-38-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, Ruby, Haskell, Perl, R, Java, Ocaml, fonts, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-lark