Bug 2227039 - Review Request: rust-listenfd - Simple library to work with listenfds passed from the outside
Summary: Review Request: rust-listenfd - Simple library to work with listenfds passed ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/listenfd
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-27 14:23 UTC by Fabio Valentini
Modified: 2023-09-01 19:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-01 19:52:11 UTC
Type: ---
Embargoed:
klember: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-07-27 14:23:44 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-listenfd.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-listenfd-1.0.1-1.fc38.src.rpm

Description:
A simple library to work with listenfds passed from the outside
(systemd/catflap socket activation).

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-07-27 14:23:47 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=104012426

Comment 2 Fabio Valentini 2023-07-27 14:25:48 UTC
This is an unretirement request. I would need this crate to enable running tests for the warp crate.

Comment 3 Fedora Review Service 2023-07-27 14:36:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6217411
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227039-rust-listenfd/fedora-rawhide-x86_64/06217411-rust-listenfd/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Kalev Lember 2023-08-30 15:07:54 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Looks nice and clean and the only changes to the package that was in Fedora before the retirement is the version bump from 1.0.0 to 1.0.1 and re-generating the spec file with newer rust2rpm.

Package APPROVED.

Comment 5 Fabio Valentini 2023-08-30 16:45:43 UTC
Thanks for the review!
https://pagure.io/releng/issue/11650

Comment 6 Fabio Valentini 2023-09-01 19:52:11 UTC
Unretired, updated, built, and built warp with re-enabled test suite. Thanks!
https://bodhi.fedoraproject.org/updates/FEDORA-2023-a21d5cfbe6


Note You need to log in before you can comment on or make changes to this bug.