Spec URL: https://jjames.fedorapeople.org/pplite/pplite.spec SRPM URL: https://jjames.fedorapeople.org/pplite/pplite-0.11-1.fc39.src.rpm Fedora Account System Username: jjames Description: PPLite is an open-source C++ library implementing the abstract domain of convex polyhedra, to be used in tools for static analysis and verification. This is a new dependency of the apron package.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6218309 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227103-pplite/fedora-rawhide-x86_64/06218309-pplite/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7118236 bytes in 124 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation -> Split the demos into a separate subpackage, with the licence, and maybe add a Recommends for it in the devel subpackage if you want? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 7118236 bytes in 124 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "GNU General Public License v3.0 or later [generated file]", "FSF Unlimited License (with License Retention) [generated file]", "GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "FSF All Permissive License", "FSF Unlimited License (with License Retention) GNU General Public License, Version 2", "FSF Unlimited License (with License Retention)". 147 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/pplite/review- pplite/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [=]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 7331840 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pplite-0.11-1.fc39.x86_64.rpm pplite-devel-0.11-1.fc39.x86_64.rpm pplite-tools-0.11-1.fc39.x86_64.rpm pplite-debuginfo-0.11-1.fc39.x86_64.rpm pplite-debugsource-0.11-1.fc39.x86_64.rpm pplite-0.11-1.fc39.src.rpm ================================================================ rpmlint session starts =============================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmph02cggii')] checks: 31, packages: 6 pplite-devel.x86_64: W: unstripped-binary-or-object /usr/share/doc/pplite-devel/demos/pplite_lcdd/.libs/pplite_lcdd pplite-devel.x86_64: W: spurious-executable-perm /usr/share/doc/pplite-devel/demos/pplite_lcdd/.libs/pplite_lcdd pplite-tools.x86_64: W: no-manual-page-for-binary pplite_lcdd pplite-tools.x86_64: W: no-documentation pplite-devel.x86_64: W: makefile-junk /usr/share/doc/pplite-devel/demos/Makefile.am pplite-devel.x86_64: W: makefile-junk /usr/share/doc/pplite-devel/demos/pplite_lcdd/Makefile.am pplite-devel.x86_64: W: makefile-junk /usr/share/doc/pplite-devel/demos/pplite_lcdd/examples/Makefile.am pplite-devel.x86_64: E: libtool-wrapper-in-package /usr/share/doc/pplite-devel/demos/pplite_lcdd/pplite_lcdd pplite-devel.x86_64: W: hidden-file-or-dir /usr/share/doc/pplite-devel/demos/pplite_lcdd/.libs pplite-devel.x86_64: W: hidden-file-or-dir /usr/share/doc/pplite-devel/demos/pplite_lcdd/.libs pplite-devel.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/pplite-devel/demos/pplite_lcdd/.libs/pplite_lcdd pplite-devel.x86_64: E: arch-dependent-file-in-usr-share /usr/share/doc/pplite-devel/demos/pplite_lcdd/pplite_lcdd.o ================================= 6 packages and 0 specfiles checked; 3 errors, 9 warnings, 3 badness; has taken 0.9 s ================================
Needinfo me when it is fixed please.
Thank you for the review @zebob.m ! On second look, I have opted to omit the demos altogether. I don't think they add enough value to bother with packaging.
LGTM then! Package approved. Please mark you thread on the forum as solved as well.
The Pagure repository was created at https://src.fedoraproject.org/rpms/pplite
Version 0.11 has been built in Rawhide.