Bug 2227208 - [regression] thin_delta doesn't accept --thin option
Summary: [regression] thin_delta doesn't accept --thin option
Keywords:
Status: MODIFIED
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: device-mapper-persistent-data
Version: 9.3
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: rc
: ---
Assignee: Ming-Hung Tsai
QA Contact: Filip Suba
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-28 10:27 UTC by Filip Suba
Modified: 2023-08-14 11:32 UTC (History)
6 users (show)

Fixed In Version: device-mapper-persistent-data-1.0.6-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-163755 0 None None None 2023-07-28 10:27:49 UTC

Description Filip Suba 2023-07-28 10:27:00 UTC 
Description of problem:
Latest release of thin_delta returns "unknown option" error message when using --thin option.


Version-Release number of selected component (if applicable):
device-mapper-persistent-data-1.0.5-1.el9


How reproducible:
always


Steps to Reproduce:
1. thin_delta /dev/mapper/vgtest-swapvol --thin1 '1' --thin2 '9'
2.
3.

Actual results:
thin_delta /dev/mapper/vgtest-swapvol --thin1 '1' --thin2 '9'
unknown option


Expected results:
thin_delta /dev/mapper/vgtest-swapvol --thin1 '1' --thin2 '9'
<superblock uuid="" time="0" transaction="10" data_block_size="128" nr_data_blocks="1600">
 <diff left="1" right="9">
  <different begin="0" length="2"/>
  <different begin="13" length="17"/>
  <different begin="128" length="1"/>
  <different begin="191" length="1"/>
 </diff>
</superblock>


Additional info:
Comment 1 Ming-Hung Tsai 2023-08-09 06:56:11 UTC 
Fixed upstream: https://github.com/jthornber/thin-provisioning-tools/commit/ee74c54521

Awaiting for the next release.
Comment 2 Ming-Hung Tsai 2023-08-09 07:58:50 UTC 
Fixed in v1.0.6 upstream. Added two more functional tests to make sure the options work as expected.

```
# cargo test [--release]
...
Running tests/thin_delta.rs 

test test_same_dev_id ... ok
test test_same_root ... ok
```
Note You need to log in before you can comment on or make changes to this bug.