Spec URL: https://heino.kim/foomuuri/foomuuri.spec SRPM URL: https://heino.kim/foomuuri/foomuuri-0.19-1.fc38.src.rpm Description: Foomuuri is a firewall generator for nftables based on the concept of zones. It is suitable for all systems from personal machines to corporate firewalls, and supports advanced features such as a rich rule language, IPv4/IPv6 rule splitting, dynamic DNS lookups, a D-Bus API and FirewallD emulation for NetworkManager's zone support. Fedora Account System Username: kimheino I'm the author of Foomuuri. I'm also doing other packaging to Fedora and EPEL (munin, sawfish). Foomuuri is already included to Debian unstable. Next version 0.20 will have more features and some fixes, for example moving man page from section 1 to 8. My plan is to package upcoming 0.20 to Fedora and EPEL9 as first release, not 0.19.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6228652 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2228032-foomuuri/fedora-rawhide-x86_64/06228652-foomuuri/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
rpmlint warnings: > foomuuri.noarch: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/foomuuri.conf This is now fixed in https://github.com/FoobarOy/foomuuri/commit/db9cecd3899bcf06db51825ef223a57381f13c91 > foomuuri.noarch: W: only-non-binary-in-usr-lib That's probably false warning, as only /usr/lib files are systemd services etc. > foomuuri.noarch: E: non-standard-dir-perm /etc/foomuuri 750 That is for security purposes. Normal user should not be able to read Foomuuri's config files. > foomuuri.noarch: E: non-standard-dir-perm /run/foomuuri 700 Fixed in above tmpfile-creation and https://github.com/FoobarOy/foomuuri/commit/2c3a215ab09642fd14fb7705754a44668088c0e5 > foomuuri-firewalld.noarch: W: no-documentation Documentation is included to main foomuuri.noarch only.
APPROVED, just fix the License tag from 'GPLv2+' to GPL-2.0-or-later Package Review ============== Issues: ======= - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'GPLv2+'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 License should be: GPL-2.0-or-later ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2". 25 files have unknown license. Detailed output of licensecheck in /home/paul.wouters/2228032-foomuuri/results/2228032-foomuuri/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1, /usr/lib/sysctl.d, /usr/share/dbus-1/system.d [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in foomuuri [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2270 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in foomuuri-firewalld Reviewer: this is correct as it is a noarch package [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Reviewer: upstream has no %check [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: foomuuri-0.19-1.fc39.noarch.rpm foomuuri-firewalld-0.19-1.fc39.noarch.rpm foomuuri-0.19-1.fc39.src.rpm ======================================================== rpmlint session starts ======================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpg9ah6v4i')] checks: 31, packages: 3 foomuuri.noarch: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/foomuuri.conf foomuuri.noarch: W: only-non-binary-in-usr-lib foomuuri.noarch: E: non-standard-dir-perm /etc/foomuuri 750 foomuuri.noarch: E: non-standard-dir-perm /run/foomuuri 700 foomuuri-firewalld.noarch: W: no-documentation ========================= 3 packages and 0 specfiles checked; 2 errors, 3 warnings, 2 badness; has taken 0.2 s ========================= Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2 foomuuri.noarch: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/foomuuri.conf foomuuri.noarch: W: only-non-binary-in-usr-lib foomuuri.noarch: E: non-standard-dir-perm /etc/foomuuri 750 foomuuri.noarch: E: non-standard-dir-perm /run/foomuuri 700 foomuuri-firewalld.noarch: W: no-documentation 2 packages and 0 specfiles checked; 2 errors, 3 warnings, 2 badness; has taken 0.0 s
The Pagure repository was created at https://src.fedoraproject.org/rpms/foomuuri
Foomuuri is now included in Fedora and EPEL.