Bug 2228351 - Review Request: rust-clang-tidy-sarif - Convert clang-tidy output to SARIF
Summary: Review Request: rust-clang-tidy-sarif - Convert clang-tidy output to SARIF
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/clang-tidy-s...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-02 07:09 UTC by Jan Macku
Modified: 2023-08-22 17:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-22 17:16:26 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2023-08-02 07:20:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6233643
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2228351-rust-clang-tidy-sarif/fedora-rawhide-x86_64/06233643-rust-clang-tidy-sarif/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-08-06 08:45:47 UTC
Binary subpackage license tag missing, see https://bugzilla.redhat.com/show_bug.cgi?id=2228346#c2

Comment 3 Jan Macku 2023-08-07 08:38:44 UTC
Updated. Thank you for review. Please have another look.

Comment 4 Fabio Valentini 2023-08-14 10:40:51 UTC
Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- license tag for binary subpackage present and correct
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Note that "(Apache-2.0 OR MIT)" and "(MIT OR Apache-2.0)" are the same (i.e. the SPDX-OR operator is commutative), you could drop the second occurrence from the License tag.

Additionally, the SPDX-AND operator is associative, so you can drop nested ANDs and simplify the license tag a bit:

License:        MIT AND Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (Unlicense OR MIT)

Comment 5 Fedora Admin user for bugzilla script actions 2023-08-14 11:08:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clang-tidy-sarif

Comment 6 Fedora Update System 2023-08-14 12:45:25 UTC
FEDORA-2023-507cafed65 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-507cafed65

Comment 7 Fedora Update System 2023-08-14 12:46:01 UTC
FEDORA-2023-5a17c33c8a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a17c33c8a

Comment 8 Fedora Update System 2023-08-15 01:18:29 UTC
FEDORA-2023-507cafed65 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-507cafed65 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-507cafed65

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-08-15 01:32:44 UTC
FEDORA-2023-5a17c33c8a has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5a17c33c8a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a17c33c8a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-08-22 17:16:26 UTC
FEDORA-2023-5a17c33c8a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-08-22 17:35:18 UTC
FEDORA-2023-507cafed65 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.