Spec URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-clang-tidy-sarif/fedora-rawhide-x86_64/06247860-rust-clang-tidy-sarif/rust-clang-tidy-sarif.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-clang-tidy-sarif/fedora-rawhide-x86_64/06247860-rust-clang-tidy-sarif/rust-clang-tidy-sarif-0.4.1-1.fc39.src.rpm Description: Convert clang-tidy output to SARIF. Fedora Account System Username: jamacku
Copr build: https://copr.fedorainfracloud.org/coprs/build/6233643 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2228351-rust-clang-tidy-sarif/fedora-rawhide-x86_64/06233643-rust-clang-tidy-sarif/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Binary subpackage license tag missing, see https://bugzilla.redhat.com/show_bug.cgi?id=2228346#c2
Updated. Thank you for review. Please have another look.
Thanks for the update! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - license tag for binary subpackage present and correct - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Note that "(Apache-2.0 OR MIT)" and "(MIT OR Apache-2.0)" are the same (i.e. the SPDX-OR operator is commutative), you could drop the second occurrence from the License tag. Additionally, the SPDX-AND operator is associative, so you can drop nested ANDs and simplify the license tag a bit: License: MIT AND Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (Unlicense OR MIT)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clang-tidy-sarif
FEDORA-2023-507cafed65 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-507cafed65
FEDORA-2023-5a17c33c8a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a17c33c8a
FEDORA-2023-507cafed65 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-507cafed65 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-507cafed65 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-5a17c33c8a has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5a17c33c8a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a17c33c8a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.