Bug 2228353 - Review Request: rust-hadolint-sarif - Convert hadolint output to SARIF
Summary: Review Request: rust-hadolint-sarif - Convert hadolint output to SARIF
Keywords:
Status: ON_QA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/hadolint-sarif
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-02 07:13 UTC by Jan Macku
Modified: 2023-08-15 01:32 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2023-08-02 07:24:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6233647
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2228353-rust-hadolint-sarif/fedora-rawhide-x86_64/06233647-rust-hadolint-sarif/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-08-06 08:46:15 UTC
Binary subpackage license tag missing, see https://bugzilla.redhat.com/show_bug.cgi?id=2228346#c2

Comment 3 Jan Macku 2023-08-07 08:21:39 UTC
Thank you, I have updated the spec file and srpm. Please have a look.

Comment 4 Fabio Valentini 2023-08-14 10:19:02 UTC
Thanks for the update!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- license tag for binary subpackage present and correct
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Note that "(Apache-2.0 OR MIT)" and "(MIT OR Apache-2.0)" are the same (i.e. the SPDX-OR operator is commutative), you could drop the second occurrence from the License tag.

Comment 5 Fedora Admin user for bugzilla script actions 2023-08-14 11:08:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hadolint-sarif

Comment 6 Fedora Update System 2023-08-14 12:38:05 UTC
FEDORA-2023-7e768907b1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7e768907b1

Comment 7 Fedora Update System 2023-08-14 12:40:22 UTC
FEDORA-2023-172a14ae13 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-172a14ae13

Comment 8 Fedora Update System 2023-08-15 01:18:23 UTC
FEDORA-2023-7e768907b1 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7e768907b1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7e768907b1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-08-15 01:32:40 UTC
FEDORA-2023-172a14ae13 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-172a14ae13 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-172a14ae13

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.


Note You need to log in before you can comment on or make changes to this bug.