Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-r3labs-diff-3.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-r3labs-diff-3-3.0.1-1.fc38.src.rpm Description: A library for diffing Golang structures. Fedora Account System Username: eclipseo
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104431955
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-r3labs-diff-3.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-r3labs-diff-3-3.0.1-1.fc38.src.rpm
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104432553
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "Mozilla Public License 2.0". 14 files have unknown license. Detailed output of licensecheck in /home/sergio/fedora-scm/docker/2229465-golang-github-r3labs- diff-3/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: (...) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 22132 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-r3labs-diff-3-devel-3.0.1-1.fc39.noarch.rpm golang-github-r3labs-diff-3-3.0.1-1.fc39.src.rpm ===================================================================== rpmlint session starts ===================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0u2fnkr1')] checks: 31, packages: 2 golang-github-r3labs-diff-3.spec: W: no-%build-section golang-github-r3labs-diff-3-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/r3labs/diff/v3/.goipath golang-github-r3labs-diff-3-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/r3labs/diff/v3/CONTRIBUTING.md /usr/share/doc/golang-github-r3labs-diff-3-devel/CONTRIBUTING.md golang-github-r3labs-diff-3-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/r3labs/diff/v3/README.md /usr/share/doc/golang-github-r3labs-diff-3-devel/README.md ====================================== 2 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.4 s ====================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 golang-github-r3labs-diff-3-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/r3labs/diff/v3/.goipath golang-github-r3labs-diff-3-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/r3labs/diff/v3/CONTRIBUTING.md /usr/share/doc/golang-github-r3labs-diff-3-devel/CONTRIBUTING.md golang-github-r3labs-diff-3-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/r3labs/diff/v3/README.md /usr/share/doc/golang-github-r3labs-diff-3-devel/README.md 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/r3labs/diff/archive/v3.0.1/diff-3.0.1.tar.gz : CHECKSUM(SHA256) this package : 10fceb7e740955dd183cf862cd8124a88ea4840e11d13868e4c901a16dbd294a CHECKSUM(SHA256) upstream package : 10fceb7e740955dd183cf862cd8124a88ea4840e11d13868e4c901a16dbd294a Requires -------- golang-github-r3labs-diff-3-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/vmihailenco/msgpack/v5) Provides -------- golang-github-r3labs-diff-3-devel: golang(github.com/r3labs/diff/v3) golang-github-r3labs-diff-3-devel golang-ipath(github.com/r3labs/diff/v3) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2229465 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: fonts, Ocaml, Python, PHP, Perl, C/C++, Haskell, SugarActivity, R, Ruby, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Looks correct to me, I don't see any issue , the rpmlint warnings are normal and the spec is clean PACKAGE APPROVED
Thank you for the review, Sergio https://pagure.io/releng/fedora-scm-requests/issue/56668
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-r3labs-diff-3