Spec URL: https://kalev.fedorapeople.org/rust-safe-transmute.spec SRPM URL: https://kalev.fedorapeople.org/rust-safe-transmute-0.11.2-5.fc39.src.rpm Description: A safeguarded transmute() for Rust. Fedora Account System Username: kalev Note that this is a re-review of a retired package and needed for packaging loupe.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6257500 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2230010-rust-safe-transmute/fedora-rawhide-x86_64/06257500-rust-safe-transmute/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me. You might want to exclude some files from getting installed (appveyor.yml, rustfmt.toml, safe-transmute-rs.sublime-project), that might also be a candidate for upstream (which looks dead, so maybe not). === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
You might want to convert to rpmautospec after importing the package.
Thanks for the review, Fabio! > Looks good to me. You might want to exclude some files from getting installed (appveyor.yml, rustfmt.toml, safe-transmute-rs.sublime-project), that might also be a candidate for upstream (which looks dead, so maybe not). What's the best way to exclude the files? I'm fairly clueless when it comes to rust. > You might want to convert to rpmautospec after importing the package. Will do, thanks.
Unretirement request: https://pagure.io/releng/issue/11603
(In reply to Kalev Lember from comment #4) > What's the best way to exclude the files? I'm fairly clueless when it comes > to rust. There are two ways - the first one is more robust. You can use the "package.exclude" setting in Cargo.toml. In this case, adding a patch to add these lines to the [package] table would do it: exclude = [ "/appveyor.yml", "/rustfmt.toml", "/safe-transmute-rs.sublime-project", ] The alternative would be to add this line to the -devel subpackage's %files list: %exclude %{crate_instdir}/{appveyor.yml,rustfmt.toml,safe-transmute-rs.sublime-project}
Thanks, Fabio! I opened a PR for that at https://github.com/nabijaczleweli/safe-transmute-rs/pull/68