Bug 2230724 - Review Request: rust-litrs - Parse and inspect Rust literals
Summary: Review Request: rust-litrs - Parse and inspect Rust literals
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/litrs
Whiteboard:
Depends On:
Blocks: 2230729
TreeView+ depends on / blocked
 
Reported: 2023-08-09 21:46 UTC by Kalev Lember
Modified: 2023-08-11 20:18 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-11 20:15:37 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2023-08-09 21:46:42 UTC
Spec URL: https://kalev.fedorapeople.org/rust-litrs.spec
SRPM URL: https://kalev.fedorapeople.org/rust-litrs-0.4.0-1.fc40.src.rpm
Description:
Parse and inspect Rust literals (i.e. tokens in the Rust programming
language representing fixed values). Particularly useful for proc
macros, but can also be used outside of a proc-macro context.

Fedora Account System Username: kalev

Comment 1 Fedora Review Service 2023-08-09 21:54:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6261728
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2230724-rust-litrs/fedora-rawhide-x86_64/06261728-rust-litrs/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-08-11 19:54:16 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Kalev Lember 2023-08-11 19:57:20 UTC
Thanks for the quick review, Fabio!

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-11 19:57:51 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-litrs

Comment 5 Fedora Update System 2023-08-11 20:13:58 UTC
FEDORA-2023-fa095f3c4f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fa095f3c4f

Comment 6 Fedora Update System 2023-08-11 20:14:14 UTC
FEDORA-2023-7ebf34cc3d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7ebf34cc3d

Comment 7 Fedora Update System 2023-08-11 20:15:37 UTC
FEDORA-2023-fa095f3c4f has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-08-11 20:18:37 UTC
FEDORA-2023-7ebf34cc3d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.