Spec URL: https://kalev.fedorapeople.org/rust-gvdb-macros.spec SRPM URL: https://kalev.fedorapeople.org/rust-gvdb-macros-0.1.8-1.fc40.src.rpm Description: Convenience macros for gvdb. Fedora Account System Username: kalev
Copr build: https://copr.fedorainfracloud.org/coprs/build/6261777 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2230732-rust-gvdb-macros/fedora-rawhide-x86_64/06261777-rust-gvdb-macros/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This crate embeds the same icons / test-data as gvdb itself. Please apply the same patch / changes.
Ah, yes, indeed. Fixed: Spec URL: https://kalev.fedorapeople.org/rust-gvdb-macros.spec SRPM URL: https://kalev.fedorapeople.org/rust-gvdb-macros-0.1.8-2.fc40.src.rpm
That was the only issue, looks good to me otherwise. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Excellent. Thank you for the super quick review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gvdb-macros
FEDORA-2023-d02a5bd514 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d02a5bd514
FEDORA-2023-434850c6f3 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-434850c6f3
FEDORA-2023-d02a5bd514 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-434850c6f3 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.