Bug 2231107 - Review Request: ansible-collection-awx-awx - AWX ansible collection
Summary: Review Request: ansible-collection-awx-awx - AWX ansible collection
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2023-08-10 15:06 UTC by Andrew Heath
Modified: 2023-08-11 14:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 6263915 to 6266611 (1.27 KB, patch)
2023-08-11 14:35 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Maxwell G 2023-08-10 21:05:38 UTC
Thanks for submitting this! I have some feedback that I can write down later. To start with, take a look at https://docs.fedoraproject.org/en-US/packaging-guidelines/Ansible_collections/#_unnecessary_files (see the example spec for how to actually apply this) and please remove the code for running tests that don't exist.

Comment 2 Maxwell G 2023-08-10 21:10:10 UTC
-Summary:	Ansible modules and plugins for working with Awx
+Summary:	Ansible modules and plugins for working with AWX

---

> echo $(ls -l)

Remove or replace with plain `ls -l`.

---

-cd %{_builddir}/awx-%{version}/awx_collection_build/
+cd awx_collection_build


---

> License:	GPL-3.0-or-later AND Apache-2.0

needs a short comment explaining the license breakdown.

---

 %description
-ansible-collection-awx-awx provides the Awx.Awx Ansible
+ansible-collection-awx-awx provides the awx.awx Ansible

---


 %changelog
 * Fri Jul 28 2023 Andrew H <aheath1992> - 22.6.0-1
-- Inital Package
+- Initial Package

Comment 3 Andrew Heath 2023-08-11 14:28:40 UTC
Updated based on recommendations and referencing other ansible-collection packages  

Spec URL: https://fedorapeople.org/cgit/aheath1992/public_git/ansible-collection-awx-awx.git/plain/ansible-collection-awx-awx.spec
SRPM URL: https://fedorapeople.org/cgit/aheath1992/public_git/ansible-collection-awx-awx.git/plain/ansible-collection-awx-awx-22.6.0-1.fc38.src.rpm
Description: AWX ansible collection in a RPM format
Fedora Account System Username: aheath1992

Comment 4 Fedora Review Service 2023-08-11 14:35:34 UTC
Created attachment 1983041 [details]
The .spec file difference from Copr build 6263915 to 6266611


Note You need to log in before you can comment on or make changes to this bug.