Bug 2231373 - Review Request: golang-modernc-ccorpus2 - Continuation of ccorpus but using embed.FS
Summary: Review Request: golang-modernc-ccorpus2 - Continuation of ccorpus but using e...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-11 12:46 UTC by W. Michael Petullo
Modified: 2023-08-15 15:13 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description W. Michael Petullo 2023-08-11 12:46:10 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccorpus2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccorpus2-1.4.1-1.fc38.src.rpm
Description:  Continuation of ccorpus but using embed.FS
Fedora Account System Username: mikep

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Robert-André Mauchin 🐧 2023-08-14 20:04:45 UTC
So I mentioned this before by mail, there is non free code in your SPEC.

WARNING: ccorpus has non free software included, you must regenerate assests.go with https://gitlab.com/cznic/assets binary after deleting the non free directories like in the SPEC:

rm -rfv assets/CompCert-3.6 assets/github.com/AbsInt/CompCert

There are a lot of assets, you need to assess the LICENCE for each project, include them in the SPEC and add a license breakdown for each project.

Comment 2 W. Michael Petullo 2023-08-15 15:13:09 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccorpus2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccorpus2-1.4.1-1.fc38.src.rpm
Description:  Continuation of ccorpus but using embed.FS
Fedora Account System Username: mikep

Thank you, Robert-André. This revision pulls license files out of the assets when available. I also updated the list of licenses in the RPM specification, and I included the bits that pull out non-free stuff.


Note You need to log in before you can comment on or make changes to this bug.