Bug 2231938 - Review Request: golang-modernc-golex - A lex/flex like (not fully POSIX lex compatible) utility
Summary: Review Request: golang-modernc-golex - A lex/flex like (not fully POSIX lex c...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2231936 2231937
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-14 17:53 UTC by W. Michael Petullo
Modified: 2023-08-20 20:00 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-20 20:00:13 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-08-14 17:53:15 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-golex.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-golex-1.0.5-1.fc38.src.rpm
Description: A lex/flex like (not fully POSIX lex compatible) utility
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-20 17:25:12 UTC
 - Don't glob the entire binary directory:

%{_bindir}/golex

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version


Note You need to log in before you can comment on or make changes to this bug.