RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2232241 - kdump role: "Write new authorized_keys if needed" task idempotency issues
Summary: kdump role: "Write new authorized_keys if needed" task idempotency issues
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: rhel-system-roles
Version: 9.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 9.3
Assignee: Rich Megginson
QA Contact: Jakub Haruda
Sujata Kurup
URL:
Whiteboard: role:kdump
Depends On:
Blocks: 2232391
TreeView+ depends on / blocked
 
Reported: 2023-08-15 21:38 UTC by Brian Smith
Modified: 2023-11-07 14:55 UTC (History)
6 users (show)

Fixed In Version: rhel-system-roles-1.22.0-1.el9
Doc Type: Bug Fix
Doc Text:
.The `kdump` role adds `authorized_keys` idempotently Previously, the task to add `authorized_key` added an extra newline character every time. Consequently the role was not acting idempotent. With this fix, adding a new `authorized_key` works correctly and adds only a single key value idempotently.
Clone Of:
: 2232391 (view as bug list)
Environment:
Last Closed: 2023-11-07 08:29:54 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github linux-system-roles kdump pull 162 0 None open fix: Write new authorized_keys if needed is not idempotent 2023-08-16 00:44:40 UTC
Red Hat Issue Tracker RHELPLAN-165879 0 None None None 2023-08-16 16:05:00 UTC
Red Hat Product Errata RHEA-2023:6390 0 None None None 2023-11-07 08:30:10 UTC

Description Brian Smith 2023-08-15 21:38:13 UTC 
Description of problem:
The "Write new authorized_keys if needed" task does not appear to be idempotent.  When running the kdump role against a single host for a second time, it will report a change for this task, and the authorized_keys file will end up with a duplicate entry.

When running the kdump role against 2 hosts, each time the role is run, it will alternate showing a change on one host, and on the next run, the other host.  The host that reports a change will have a duplicate entry in the authorized_keys file

Version-Release number of selected component (if applicable):
rhel-system-roles-1.21.1-1.el9_2.noarch

How reproducible:
Every time

Steps to Reproduce:
1. From my controlnode (rhel9-controlnode.example.com) use this inventory file and run the kdump system role several times:

all:
  hosts:
    rhel9-server1.example.com:
    rhel9-server2.example.com:
  vars:
    kdump_target:
      type: ssh
      location: kdump.com
    kdump_path: "/home/kdump/crash"
    kdump_sshkey: "/root/.ssh/kdump_id_rsa"
    kdump_ssh_user: kdump
    kdump_ssh_server: rhel9-controlnode.example.com


Actual results:
After the initial run, subsequent runs of the role report a change on the "Write new authorized_keys if needed" task, alternating each time between showing the change on rhel9-server1.example.com and rhel9-server2.example.com.  The host that reports a change will have a duplicate entry in the authorized_keys file

Expected results:
This task is idempotent and does not report changes on subsequent runs.  Entries are not duplicated in the authorized_keys file.
Comment 1 Rich Megginson 2023-08-16 00:44:41 UTC 
@briasmit can you try out the patch in https://github.com/linux-system-roles/kdump/pull/162 ?
Comment 3 Brian Smith 2023-08-16 19:14:33 UTC 
@rmeggins Yes, this fixed the issue for me.  Thanks!
Comment 9 errata-xmlrpc 2023-11-07 08:29:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:6390
Note You need to log in before you can comment on or make changes to this bug.