Spec URL: https://petersen.fedorapeople.org/reviews/jl/jl.spec SRPM URL: https://petersen.fedorapeople.org/reviews/jl/jl-0.1.0-1.fc40.src.rpm Description: Jl ("JSON lambda") is a tiny functional language for querying and manipulating JSON. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104951950
Copr build: https://copr.fedorainfracloud.org/coprs/build/6311501 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2232543-jl/fedora-rawhide-x86_64/06311501-jl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'm currently not a packager. This is only an informal review. Note: I snipped lots of unused-direct-shlib-dependency and undefined-non-weak-symbol errors from the rpmlint result. There are just too many ~ 2,000 lines. I assume those are just false positives related to how GHC library packages are generated. There's no MUST violations so I think this package should be approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - SHOULD: The changelog should be generated automatically from git commit logs using the %autochangelog macro - SHOULD: Packages should contain them for all executables. Note: W: no-manual-page-for-binary jl ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. Note: ghc-jl-devel and ghc-jl-prof does not install the LICENSE file but they depends on the ghc-jl package so this is allowed by the policy. [x]: Package requires other packages for directories it uses. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. Note: debuginfo is currently disabled for Haskell packages, because ghc’s Dwarf output is not very useful. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 16080 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jl-0.1.0-1.fc41.x86_64.rpm ghc-jl-0.1.0-1.fc41.x86_64.rpm ghc-jl-devel-0.1.0-1.fc41.x86_64.rpm ghc-jl-prof-0.1.0-1.fc41.x86_64.rpm jl-0.1.0-1.fc41.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpz3eaol05')] checks: 32, packages: 5 ghc-jl-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/jl-0.1.0/libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g.a ghc-jl-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/jl-0.1.0/libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g_p.a jl.src: E: spelling-error ('sed', 'Summary(en_US) sed -> tied, ed, seed') jl.x86_64: E: spelling-error ('sed', 'Summary(en_US) sed -> tied, ed, seed') jl.x86_64: W: position-independent-executable-suggested /usr/bin/jl jl.x86_64: W: no-manual-page-for-binary jl ghc-jl.x86_64: W: no-documentation ghc-jl-prof.x86_64: W: no-documentation ========= 5 packages and 0 specfiles checked; 4 errors, 4 warnings, 24 filtered, 4 badness; has taken 0.7 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 jl.x86_64: W: unused-direct-shlib-dependency /usr/bin/jl /lib64/libz.so.1 **NOTE**: lots of unused-direct-shlib-dependency and undefined-non-weak-symbol errors snipped ghc-jl-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/jl-0.1.0/libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g_p.a ghc-jl-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/jl-0.1.0/libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g.a jl.x86_64: E: spelling-error ('sed', 'Summary(en_US) sed -> tied, ed, seed') jl.x86_64: W: position-independent-executable-suggested /usr/bin/jl jl.x86_64: W: no-manual-page-for-binary jl ghc-jl.x86_64: W: no-documentation ghc-jl-prof.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 2002 errors, 5 warnings, 20 filtered, 2002 badness; has taken 1.0 s Unversioned so-files -------------------- ghc-jl: /usr/lib64/ghc-9.4.5/lib/libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g-ghc9.4.5.so Source checksums ---------------- https://hackage.haskell.org/package/jl-0.1.0/jl-0.1.0.tar.gz : CHECKSUM(SHA256) this package : 72d25200fd5cb3c21b4cacd75ba5c5c4459b2a6acc85675bc5855dc9f5b07b97 CHECKSUM(SHA256) upstream package : 72d25200fd5cb3c21b4cacd75ba5c5c4459b2a6acc85675bc5855dc9f5b07b97 Requires -------- jl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libffi.so.8()(64bit) libffi.so.8(LIBFFI_BASE_8.0)(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) ghc-jl (rpmlib, GLIBC filtered): libHSOneTuple-0.4.1.1-Fgk8ylTtnzLBSBvZAI1OoV-ghc9.4.5.so()(64bit) libHSQuickCheck-2.14.3-6dq2izV8oSq1BobaDA598X-ghc9.4.5.so()(64bit) libHSStateVar-1.2.2-GlWluWgK8kgE7IUHzo2idN-ghc9.4.5.so()(64bit) libHSaeson-2.1.2.1-5k0SkOYVpUV25ecC9ACqgk-ghc9.4.5.so()(64bit) libHSarray-0.5.4.0-ghc9.4.5.so()(64bit) libHSassoc-1.1-H3gdf0Ue1d5sn9822dJ4G-ghc9.4.5.so()(64bit) libHSattoparsec-0.14.4-1rgNxdaX2hcAlnLLYxTxu4-ghc9.4.5.so()(64bit) libHSattoparsec-0.14.4-K6WkGQxU67DICICjfpE0Kf-attoparsec-internal-ghc9.4.5.so()(64bit) libHSbase-4.17.1.0-ghc9.4.5.so()(64bit) libHSbase-compat-0.12.3-EzIEO7DrtWn73MXq9N0DKk-ghc9.4.5.so()(64bit) libHSbase-compat-batteries-0.12.3-EvvecFThiaEAGWq5U5Tpi9-ghc9.4.5.so()(64bit) libHSbase-orphans-0.9.0-9apYLvrFDmLG6M4gvFHbpN-ghc9.4.5.so()(64bit) libHSbifunctors-5.5.15-6nVSldbcYfb1Hx6EfFS3QB-ghc9.4.5.so()(64bit) libHSbinary-0.8.9.1-ghc9.4.5.so()(64bit) libHSbytestring-0.11.4.0-ghc9.4.5.so()(64bit) libHScomonad-5.0.8-FA2TFGr0sUX2CXTeetXIjJ-ghc9.4.5.so()(64bit) libHScontainers-0.6.7-ghc9.4.5.so()(64bit) libHScontravariant-1.5.5-K71YSUvfKnA5wfNaE05Lao-ghc9.4.5.so()(64bit) libHSdata-fix-0.3.2-LdyR2jsAdh33KJZuVTGWPw-ghc9.4.5.so()(64bit) libHSdeepseq-1.4.8.0-ghc9.4.5.so()(64bit) libHSdistributive-0.6.2.1-1BZ9uzs8FJL3Ql0Nb5N15f-ghc9.4.5.so()(64bit) libHSdlist-1.0-IFuzLQmoMUfAx3b8iqx3U0-ghc9.4.5.so()(64bit) libHSexceptions-0.10.5-ghc9.4.5.so()(64bit) libHSfilepath-1.4.2.2-ghc9.4.5.so()(64bit) libHSfoldable1-classes-compat-0.1-JP9wXcYYGsT10VsvIV9rpl-ghc9.4.5.so()(64bit) libHSgenerically-0.1.1-L3QdfHIOuV28cUChwEJCH9-ghc9.4.5.so()(64bit) libHSghc-bignum-1.3-ghc9.4.5.so()(64bit) libHSghc-boot-th-9.4.5-ghc9.4.5.so()(64bit) libHSghc-prim-0.9.0-ghc9.4.5.so()(64bit) libHShashable-1.4.2.0-FFBRhuY0w4YLmuLEs5uQAt-ghc9.4.5.so()(64bit) libHSindexed-traversable-0.1.2.1-1XiSi5jKFt6BqKufaNXxBs-ghc9.4.5.so()(64bit) libHSindexed-traversable-instances-0.1.1.2-FygVB8lg04g7si54bMCK2n-ghc9.4.5.so()(64bit) libHSinteger-logarithms-1.0.3.1-Hm9v2fsfG1DA5soPSLssZu-ghc9.4.5.so()(64bit) libHSmtl-2.2.2-ghc9.4.5.so()(64bit) libHSparsec-3.1.16.1-ghc9.4.5.so()(64bit) libHSpretty-1.1.3.6-ghc9.4.5.so()(64bit) libHSprimitive-0.8.0.0-9akshChOwtr20iwuM0c3WJ-ghc9.4.5.so()(64bit) libHSrandom-1.2.1.1-I0wUgAAbf0g3qHR3e8uT0o-ghc9.4.5.so()(64bit) libHSscientific-0.3.7.0-6Dx8mxA4OUsLpkNxWfBzuf-ghc9.4.5.so()(64bit) libHSsemialign-1.3-62CCXIMeDFUEayGNnIlUOw-ghc9.4.5.so()(64bit) libHSsemigroupoids-5.3.7-EwVAefNzd7V4YfDIPx08VG-ghc9.4.5.so()(64bit) libHSsplitmix-0.1.0.4-7e8CibdlMRLAGh7KO5VlFe-ghc9.4.5.so()(64bit) libHSstm-2.5.1.0-ghc9.4.5.so()(64bit) libHSstrict-0.5-BMGWBclA5sg312fCUlbuTw-ghc9.4.5.so()(64bit) libHStagged-0.8.7-CYOhX22Df3PFW5V1S0dOJa-ghc9.4.5.so()(64bit) libHStemplate-haskell-2.19.0.0-ghc9.4.5.so()(64bit) libHStext-2.0.2-ghc9.4.5.so()(64bit) libHStext-short-0.1.5-9gNCeWi9Qvt3nghYino5yd-ghc9.4.5.so()(64bit) libHSth-abstraction-0.4.5.0-8bY5lBPMorfFW3yG6gFNZT-ghc9.4.5.so()(64bit) libHSthese-1.2-3gvRWs9hjHpLbWG1JfTveA-ghc9.4.5.so()(64bit) libHStime-1.12.2-ghc9.4.5.so()(64bit) libHStime-compat-1.9.6.1-8Cae3qDcmKjD7K7ztRFEOq-ghc9.4.5.so()(64bit) libHStransformers-0.5.6.2-ghc9.4.5.so()(64bit) libHStransformers-compat-0.7.2-7jAnhjvxTABIymoNGHTOwd-ghc9.4.5.so()(64bit) libHSunix-2.7.3-ghc9.4.5.so()(64bit) libHSunordered-containers-0.2.19.1-KblUXVJ0SvRCcK89PoBx7E-ghc9.4.5.so()(64bit) libHSuuid-types-1.0.5-LsoYQ81hhMAHUqibNrLXkM-ghc9.4.5.so()(64bit) libHSvector-0.13.0.0-DgEUYCaCm1GEZ2KanedKXr-ghc9.4.5.so()(64bit) libHSvector-stream-0.1.0.0-C5Yyq3DPEhXAQSqkM8V92s-ghc9.4.5.so()(64bit) libHSwitherable-0.4.2-1PEaCFJkbyYIFotYA3j6vg-ghc9.4.5.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) ghc-jl-devel (rpmlib, GLIBC filtered): ghc-compiler ghc-devel(aeson-2.1.2.1-5k0SkOYVpUV25ecC9ACqgk) ghc-devel(attoparsec-0.14.4-1rgNxdaX2hcAlnLLYxTxu4) ghc-devel(base-4.17.1.0) ghc-devel(bytestring-0.11.4.0) ghc-devel(containers-0.6.7) ghc-devel(exceptions-0.10.5) ghc-devel(mtl-2.2.2) ghc-devel(parsec-3.1.16.1) ghc-devel(scientific-0.3.7.0-6Dx8mxA4OUsLpkNxWfBzuf) ghc-devel(text-2.0.2) ghc-devel(unordered-containers-0.2.19.1-KblUXVJ0SvRCcK89PoBx7E) ghc-devel(vector-0.13.0.0-DgEUYCaCm1GEZ2KanedKXr) ghc-jl(x86-64) ghc-jl-prof (rpmlib, GLIBC filtered): ghc-jl-devel(x86-64) ghc-prof(aeson-2.1.2.1-5k0SkOYVpUV25ecC9ACqgk) ghc-prof(attoparsec-0.14.4-1rgNxdaX2hcAlnLLYxTxu4) ghc-prof(base-4.17.1.0) ghc-prof(bytestring-0.11.4.0) ghc-prof(containers-0.6.7) ghc-prof(exceptions-0.10.5) ghc-prof(mtl-2.2.2) ghc-prof(parsec-3.1.16.1) ghc-prof(scientific-0.3.7.0-6Dx8mxA4OUsLpkNxWfBzuf) ghc-prof(text-2.0.2) ghc-prof(unordered-containers-0.2.19.1-KblUXVJ0SvRCcK89PoBx7E) ghc-prof(vector-0.13.0.0-DgEUYCaCm1GEZ2KanedKXr) Provides -------- jl: jl jl(x86-64) ghc-jl: ghc-jl ghc-jl(x86-64) libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g-ghc9.4.5.so()(64bit) ghc-jl-devel: ghc-devel(jl-0.1.0-wnwQhNWQly8IFCmj8qC6g) ghc-jl-devel ghc-jl-devel(x86-64) ghc-jl-static ghc-jl-static(x86-64) ghc-jl-prof: ghc-jl-prof ghc-jl-prof(x86-64) ghc-prof(jl-0.1.0-wnwQhNWQly8IFCmj8qC6g) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2232543 -P Haskell Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Haskell, C/C++ Disabled plugins: fonts, PHP, Perl, Ocaml, Java, R, SugarActivity, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for looking at the package. (In reply to Kan-Ru Chen from comment #2) > Note: I snipped lots of unused-direct-shlib-dependency and > undefined-non-weak-symbol errors from the rpmlint result. There > are just too many ~ 2,000 lines. I assume those are just false > positives related to how GHC library packages are generated. Right... unfortunately upstream is taking a long time addressing this longstanding issue. Let me open a PR to cover it in the Haskell Packaging Policy. > > There's no MUST violations so I think this package should be approved. > > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > - SHOULD: The changelog should be generated automatically from git commit > logs > using the %autochangelog macro I generally do this after importing, but yes it is good point. Perhaps I should try start to do reviews with it. > - SHOULD: Packages should contain them for all executables. > Note: W: no-manual-page-for-binary jl I think I should update cabal-rpm to handle this. Otherwise I can add it in, with help2man.
There's no MUST violations so I think this package can be approved.
Thank you for the review, Kan-Ru
The Pagure repository was created at https://src.fedoraproject.org/rpms/jl
Created attachment 2023615 [details] full review output for reference (400kB gunzipped) Just attaching the full review.txt file here for future reference
> ghc-jl-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/jl-0.1.0/libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g.a This is currently expected: https://docs.fedoraproject.org/en-US/packaging-guidelines/Haskell/#_debuginfo but perhaps it could be fixed by turning dwarf for ghc: not sure on the current upstream status. > ghc-jl.x86_64: E: undefined-non-weak-symbol /usr/lib64/ghc-9.4.5/lib/libHSjl-0.1.0-wnwQhNWQly8IFCmj8qC6g-ghc9.4.5.so RtsFlags (/usr/lib64/ghc-9.4.5/lib/x86_64-linux-ghc-9.4.5/libHSbase-4.17.1.0-ghc9.4.5.so) : (over 1900 of these errors) https://gitlab.haskell.org/ghc/ghc/-/issues/23216 is the upstream bug I just opened https://pagure.io/packaging-committee/pull-request/1347 to document this in the packaging policy, thanks
FEDORA-2024-7f3055d351 (jl-0.1.0-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f3055d351
FEDORA-2024-7f3055d351 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7f3055d351 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f3055d351 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9235d6f063 (jl-0.1.0-2.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9235d6f063
FEDORA-2024-9235d6f063 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-9235d6f063 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-9235d6f063 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-9235d6f063 (jl-0.1.0-2.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7f3055d351 (jl-0.1.0-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.