Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2233136

Summary:	Tripleo template parameter CinderNetappNfsShares is not interpreted correctly
Product:	Red Hat OpenStack	Reporter:	mlaniel
Component:	puppet-tripleo	Assignee:	Alan Bishop <abishop>
Status:	CLOSED ERRATA	QA Contact:	Yosi Ben Shimon <ybenshim>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	17.1 (Wallaby)	CC:	abishop, aruffin, broose, fboboc, fpalin, gbrinn, jjoyce, joflynn, jschluet, ltoscano, mburns, slinaber, tvignaud, yrabl
Target Milestone:	z2	Keywords:	Triaged, ZStream
Target Release:	17.1
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	puppet-tripleo-14.2.3-17.1.20231102190827.40278e1.el9ost	Doc Type:	Bug Fix
Doc Text:	Before this update, when multiple values were provided in a comma-delimited list, the `CinderNetappNfsShares` parameter was incorrectly parsed. As a result, a NetApp back end with multiple NFS shares could not be defined. With this update, the `CinderNetappNfsShares` parameter is correctly parsed when provided with multiple values in a comma-delimited list. As a result, a NetApp with multiple NFS shares is correctly defined.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-16 14:30:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description mlaniel 2023-08-21 14:58:31 UTC

It seems CinderNetappNfsShares interpretation changed between RHOSP 16.x and RHOSP 17.
The resulting shares.conf is now invalid when using the same values as before.

If this change is expected and previous method is deprecated/abandoned, it could introduce unnecessary risk during RHOSP upgrades.


Reproducible: Always

Steps to Reproduce:
Use CinderNetappNfsShares like you would in RHOSP16.2:
CinderNetappNfsShares: '[xx:xx:xx:xx:xx:xx]:/cinder_01,[xx:xx:xx:xx:xx:yy]:/cinder_02'


Actual Results:  
/var/lib/config-data/puppet-generated/cinder/etc/cinder/shares.conf will look like:
[xx:xx:xx:xx:xx:xx]:/cinder_01,[xx:xx:xx:xx:xx:yy]:/cinder_02

Expected Results:  
/var/lib/config-data/puppet-generated/cinder/etc/cinder/shares.conf should look like:
[xx:xx:xx:xx:xx:xx]:/cinder_01
[xx:xx:xx:xx:xx:yy]:/cinder_02

The CinderNetappNfsShares type was defined in RHOSP13 doc but I could not find newer version of the doc
https://access.redhat.com/documentation/en-us/red_hat_openstack_platform/13/html-single/netapp_block_storage_back_end_guide/index#edityaml

Comment 4 Alan Bishop 2023-09-05 14:37:00 UTC

Thank you, Everyone, for the excellent triage info.

I will look more carefully at where to apply the necessary fix. It may involve THT, puppet-tripleo, possibly both.

Comment 5 Alan Bishop 2023-09-06 22:55:43 UTC

After careful consideration, I chose to fix this in puppet-tripleo.

I agree that THT's CinderNetappNfsShares should really be a comma delimited list, but that alone would not be sufficient given the possibility of it also appearing in the CinderNetappMultiConfig dictionary that supports configuring multiple NetApp backends.

Converting a list of shares in string into an array in puppet-tripleo ensures the conversion happens everywhere, and also ensures things work when upgrading from a release that didn't support CinderNetappMultiConfig.

Comment 25 errata-xmlrpc 2024-01-16 14:30:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 17.1.2 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2024:0209