Bug 2233226 - Review Request: rust-lcms2 - ICC color profile handling. Rusty wrapper for Little CMS
Summary: Review Request: rust-lcms2 - ICC color profile handling. Rusty wrapper for Li...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/lcms2
Whiteboard:
Depends On: 2231910
Blocks: 2233248
TreeView+ depends on / blocked
 
Reported: 2023-08-21 18:39 UTC by Kalev Lember
Modified: 2023-08-21 19:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-21 19:42:37 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2023-08-21 18:39:16 UTC
Spec URL: https://kalev.fedorapeople.org/rust-lcms2.spec
SRPM URL: https://kalev.fedorapeople.org/rust-lcms2-5.6.0-1.fc40.src.rpm
Description:
ICC color profile handling. Rusty wrapper for Little CMS.

Fedora Account System Username: kalev

Comment 1 Fedora Review Service 2023-08-21 18:48:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6329678
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2233226-rust-lcms2/fedora-rawhide-x86_64/06329678-rust-lcms2/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-08-21 19:22:39 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
~ test suite is run and all unit tests pass (skipped on non-x86)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please file an issue about the failing tests upstream.

Comment 3 Kalev Lember 2023-08-21 19:30:01 UTC
Will do. Thanks for the quick review!

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-21 19:30:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lcms2

Comment 5 Fedora Update System 2023-08-21 19:41:46 UTC
FEDORA-2023-3e2d10ea72 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3e2d10ea72

Comment 6 Fedora Update System 2023-08-21 19:42:22 UTC
FEDORA-2023-09b0b919d2 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-09b0b919d2

Comment 7 Fedora Update System 2023-08-21 19:42:37 UTC
FEDORA-2023-3e2d10ea72 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-08-21 19:45:37 UTC
FEDORA-2023-09b0b919d2 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.