Spec URL: https://dcavalca.fedorapeople.org/review/pianobar/pianobar.spec SRPM URL: https://dcavalca.fedorapeople.org/review/pianobar/pianobar-2022.04.01-4.fc40.src.rpm Description: pianobar is a free/open-source, console-based client for the personalized online radio Pandora. Features * play and manage (create, add more music, delete, rename, ...) stations * rate songs and explain why they have been selected * upcoming songs/song history * customize keybindings and text output * remote control and eventcmd interface (send tracks to last.fm, for example) * proxy support for listeners outside the USA Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=105150617
This package is based on the one in rpmfusion: https://admin.rpmfusion.org/pkgdb/package/free/pianobar/ Another version was previously submitted in https://bugzilla.redhat.com/show_bug.cgi?id=1028712
Copr build: https://copr.fedorainfracloud.org/coprs/build/6335593 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2233678-pianobar/fedora-rawhide-x86_64/06335593-pianobar/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please replace: BuildRequires: ffmpeg-free-devel with correct BuildRequires: pkgconfig(libavcodec) BuildRequires: pkgconfig(libavformat) BuildRequires: pkgconfig(libavutil) BuildRequires: pkgconfig(libavfilter) Upstream checking for these: libavcodec libavformat libavutil libavfilter https://github.com/PromyLOPh/pianobar/blob/master/Makefile#L49 Upstream is signing tarballs, please add signature checking.
Upstream seems to build a library, too, maybe worth including? https://github.com/PromyLOPh/pianobar/blob/master/Makefile#L135
Spec URL: https://dcavalca.fedorapeople.org/review/pianobar/pianobar.spec SRPM URL: https://dcavalca.fedorapeople.org/review/pianobar/pianobar-2022.04.01-5.fc40.src.rpm Changelog: - Adjust BuildRequires for ffmpeg - Perform checksum and signature checking for source tarball - Preserve timestamps on install - Package shared library and development headers
Copr build: https://copr.fedorainfracloud.org/coprs/build/6338141 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2233678-pianobar/srpm-builds/06338141/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The main package should also have a versioned dependency on the library subpackage too.
Package builds fine in rawhide mock. rpmlint has a complaint: pianobar.spec:65: E: use-of-RPM_SOURCE_DIR pianobar-devel.x86_64: W: no-documentation but this is sha256 checksum verification, so we can ignore it. License is correct and valid SPDX. Application is console-based, so no desktop file required. There's an rpmbuild warning to be addressed: RPM build warnings: File listed twice: /usr/lib64/libpiano.so.0 You're missing a dot before the asterisk (*) in the line below: %{_libdir}/libpiano.so.0{,*} The package looks good otherwise, though I can't test it apart from that it doesn't crash on startup, because it requires a pandora.com account. Please address Neal's comment and the one above and the package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/pianobar
FEDORA-2023-4d83d60698 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4d83d60698
FEDORA-2023-08acc17d13 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-08acc17d13
FEDORA-2023-4d83d60698 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-4d83d60698 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4d83d60698 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-08acc17d13 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-08acc17d13 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-08acc17d13 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-08acc17d13 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-4d83d60698 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.