Spec URL: https://kalev.fedorapeople.org/rust-qoi.spec SRPM URL: https://kalev.fedorapeople.org/rust-qoi-0.4.1-1.fc40.src.rpm Description: VERY fast encoder/decoder for QOI (Quite Okay Image) format. Fedora Account System Username: kalev Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=105179013 This is a new dep for rust-image (and used in loupe).
Copr build: https://copr.fedorainfracloud.org/coprs/build/6337472 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2233787-rust-qoi/fedora-rawhide-x86_64/06337472-rust-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (with explanation for skipped tests) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === You might want to exclude the "doc" directory too, it's just a PDF that's not used by the build process. You could use a Cargo.toml patch like this: -exclude = ["assets/*"] +exclude = ["assets/*", "doc", "ext"] This could also replace the removal of "ext" in %prep.
Thanks for the quick review, Fabio! > You might want to exclude the "doc" directory too, it's just a PDF that's not used by the build process. > You could use a Cargo.toml patch like this: > > -exclude = ["assets/*"] > +exclude = ["assets/*", "doc", "ext"] Do you think it would be worth doing it? Then we'd have another downstream patch that is going to need updating when updating to new upstream versions etc. Or is it something that could go upstream?
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-qoi
In this case the patch would be acceptable for upstream. Neither the doc nor the ext directories are used for the functionality or build of the published crates, they only serve a purpose inside upstream git.
Makes sense. Let me do an upstream PR and see how it goes.
FEDORA-2023-cc5007a651 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-cc5007a651
FEDORA-2023-cc5007a651 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
(In reply to Kalev Lember from comment #6) > Makes sense. Let me do an upstream PR and see how it goes. PR opened: https://github.com/aldanor/qoi-rust/pull/7