Spec URL: https://kalev.fedorapeople.org/rust-four-cc.spec SRPM URL: https://kalev.fedorapeople.org/rust-four-cc-0.3.0-1.fc40.src.rpm Description: Newtype wrapper providing a convenient representation of four-character- code values. Fedora Account System Username: kalev Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=105287206
Copr build: https://copr.fedorainfracloud.org/coprs/build/6343548 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2234761-rust-four-cc/fedora-rawhide-x86_64/06343548-rust-four-cc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two minor issues: 1. It looks like you disabled schemars and zerocopy support, please remember to import the rust2rpm.conf file you used as well. 2. The summary is too long, from rpmlint: rust-four-cc+serde-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc+default-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc+std-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values rust-four-cc+nightly-devel.noarch: E: summary-too-long Newtype wrapper providing a convenient representation of four-character-code values Please trim to something shorter (maybe "Convenient representation of four-character-code values"). Not sure what four-character-code is though, so ... feel free to come up with something better. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thanks a lot for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-four-cc
(In reply to Fabio Valentini from comment #2) > Two minor issues: > > 1. It looks like you disabled schemars and zerocopy support, please remember > to import the rust2rpm.conf file you used as well. Yes, of course, I already had it commited locally. > 2. The summary is too long, from rpmlint: > > Please trim to something shorter (maybe "Convenient representation of > four-character-code values"). > Not sure what four-character-code is though, so ... feel free to come up > with something better. Thanks, fixed! I went with "Newtype wrapper for representing four-character-code values" - https://src.fedoraproject.org/rpms/rust-four-cc/c/978a1ac79dc2c520eb51971b500768c79a89487f?branch=rawhide
FEDORA-2023-1eb3bbdf62 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1eb3bbdf62
FEDORA-2023-1eb3bbdf62 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.