Spec URL: https://eclipseo.fedorapeople.org/for-review/python-extractcode.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-extractcode-31.0.0-1.fc38.src.rpm Description: A mostly universal file extraction library and CLI tool to extract almost any archive in a reasonably safe way on Linux, macOS and Windows. Fedora Account System Username: eclipseo To build it against the dependencies, use the following COPR in your rawhide mock.cfg: [copr:copr.fedorainfracloud.org:eclipseo:scancode-toolkit] name=Copr repo for scancode-toolkit owned by eclipseo baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/fedora-rawhide-/ type=rpm-md skip_if_unavailable=True gpgcheck=1 gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/pubkey.gpg repo_gpgcheck=0 enabled=1 enabled_metadata=1
Copr build: https://copr.fedorainfracloud.org/coprs/build/6345541 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235061-python-extractcode/fedora-rawhide-x86_64/06345541-python-extractcode/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I will take this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues ------ - Note the following in the build log, since 2023-Sep-26 is in 2 weeks: /usr/lib/python3.12/site-packages/setuptools/dist.py:755: SetuptoolsDeprecationWarning: Invalid dash-separated options !! ******************************************************************************** Usage of dash-separated 'console-scripts' will not be supported in future versions. Please use the underscore name 'console_scripts' instead. By 2023-Sep-26, you need to update your project and remove deprecated calls or your builds will no longer be supported. See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details. ******************************************************************************** !! opt = self.warn_dash_deprecation(opt, section) - The License field should be "Apache-2.0 AND MIT". Notice the MIT license in the extractcode script, for the realpath family of functions. - All of the tests in tests/test_patch.py are skipped. The reason is that Fedora doesn't have a package for https://pypi.org/project/patch/. However, we do have https://pypi.org/project/patch-ng/. If extractcode upstream could be convinced to switch from patch to patch-ng, those tests would be useful again. - I question the value of including CODE_OF_CONDUCT.rst in %doc. - Note the rpmlint summary-too-long warning. Perhaps it could be "File extraction library and CLI tool to extract almost any archive" or "File extraction library and CLI tool for almost any archive"? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "MIT License Apache License 2.0", "MIT License", "*No copyright* MIT License", "BSD 2-Clause with views sentence", "MIT License BSD 2-Clause with views sentence", "GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 3", "GNU General Public License", "BSD 3-Clause License GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "GNU General Public License, Version 2 [obsolete FSF postal address (Temple Place)]", "*No copyright* GNU General Public License", "GNU Library General Public License v2 or later", "GNU Lesser General Public License". 851 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 23657 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-extractcode-31.0.0-1.fc40.noarch.rpm python3-extractcode+full-31.0.0-1.fc40.noarch.rpm python-extractcode-doc-31.0.0-1.fc40.noarch.rpm python-extractcode-31.0.0-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvhklnqsc')] checks: 31, packages: 4 python-extractcode.src: E: summary-too-long Mostly universal file extraction library and CLI tool to extract almost any archive python3-extractcode.noarch: E: summary-too-long Mostly universal file extraction library and CLI tool to extract almost any archive python3-extractcode.noarch: W: no-manual-page-for-binary extractcode python3-extractcode+full.noarch: W: no-documentation ================= 4 packages and 0 specfiles checked; 2 errors, 2 warnings, 2 badness; has taken 0.6 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 python3-extractcode.noarch: E: summary-too-long Mostly universal file extraction library and CLI tool to extract almost any archive python3-extractcode.noarch: W: no-manual-page-for-binary extractcode python3-extractcode+full.noarch: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.0 s Source checksums ---------------- https://github.com/nexB/extractcode/archive/v31.0.0/extractcode-31.0.0.tar.gz : CHECKSUM(SHA256) this package : fe53a1f584c75e87a0afdea9fdde3397297168ad817d4edf404181068c717289 CHECKSUM(SHA256) upstream package : fe53a1f584c75e87a0afdea9fdde3397297168ad817d4edf404181068c717289 Requires -------- python3-extractcode (rpmlib, GLIBC filtered): ((python3.12dist(attrs) < 20.1 or python3.12dist(attrs) > 20.1) with python3.12dist(attrs) >= 18.1) /usr/bin/python3 python(abi) python3.12dist(commoncode) python3.12dist(plugincode) python3.12dist(six) python3.12dist(typecode) python3-extractcode+full (rpmlib, GLIBC filtered): python(abi) python3-extractcode python3.12dist(extractcode-7z-system-provided) python3.12dist(extractcode-libarchive-system-provided) python3.12dist(typecode) python3.12dist(typecode[full]) python-extractcode-doc (rpmlib, GLIBC filtered): Provides -------- python3-extractcode: python-extractcode python3-extractcode python3.12-extractcode python3.12dist(extractcode) python3dist(extractcode) python3-extractcode+full: python-extractcode+full python3-extractcode+full python3.12-extractcode+full python3.12dist(extractcode[full]) python3dist(extractcode[full]) python-extractcode-doc: python-extractcode-doc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2235061 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-eclipseo Active plugins: Generic, Shell-api, Python Disabled plugins: R, PHP, C/C++, fonts, Haskell, Ocaml, Perl, Java, Ruby, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks for the review! Spec URL: https://eclipseo.fedorapeople.org/for-review/python-extractcode.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-extractcode-31.0.0-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6528086 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235061-python-extractcode/fedora-rawhide-x86_64/06528086-python-extractcode/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
That looks good. This package is APPROVED.
Thank you for the review, Jerry https://pagure.io/releng/fedora-scm-requests/issue/57435
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-extractcode
FEDORA-2023-b7d826050d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b7d826050d
FEDORA-2023-fe2d4f4f3f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fe2d4f4f3f
FEDORA-2023-fe2d4f4f3f has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-fe2d4f4f3f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fe2d4f4f3f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-b7d826050d has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b7d826050d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b7d826050d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-fe2d4f4f3f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-b7d826050d has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.