Spec URL: https://luk1337.fedorapeople.org/review/nginx-mod-fancyindex.spec SRPM URL: https://luk1337.fedorapeople.org/review/nginx-mod-fancyindex-0.5.2-1.fc40.src.rpm Description: Nginx FancyIndex module Fedora Account System Username: luk1337
Copr build: https://copr.fedorainfracloud.org/coprs/build/6347594 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235167-nginx-mod-fancyindex/fedora-rawhide-x86_64/06347594-nginx-mod-fancyindex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Created attachment 1985520 [details] The .spec file difference from Copr build 6347594 to 6347623
Copr build: https://copr.fedorainfracloud.org/coprs/build/6347623 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235167-nginx-mod-fancyindex/fedora-rawhide-x86_64/06347623-nginx-mod-fancyindex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6347628 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235167-nginx-mod-fancyindex/fedora-rawhide-x86_64/06347628-nginx-mod-fancyindex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Could you please add `%doc CHANGELOG.md` so it is easy to check what changed on upgrades. Also you should verify the signature you include, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_verifying_signatures
Created attachment 1994566 [details] The .spec file difference from Copr build 6347628 to 6547151
Copr build: https://copr.fedorainfracloud.org/coprs/build/6547151 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235167-nginx-mod-fancyindex/fedora-rawhide-x86_64/06547151-nginx-mod-fancyindex/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I think the following line is missing: Requires: nginx
Doesn't seem like [nginx-mod-naxsi, nginx-mod-vts, nginx-mod-modsecurity] have it, but I added it regardless. [fedora-review-service-build]
Spec URL: https://luk1337.fedorapeople.org/review/nginx-mod-fancyindex.spec SRPM URL: https://luk1337.fedorapeople.org/review/nginx-mod-fancyindex-0.5.2-1.fc40.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/nginx [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 27602 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: nginx-mod-fancyindex-0.5.2-1.fc40.x86_64.rpm nginx-mod-fancyindex-debuginfo-0.5.2-1.fc40.x86_64.rpm nginx-mod-fancyindex-debugsource-0.5.2-1.fc40.x86_64.rpm nginx-mod-fancyindex-0.5.2-1.fc40.src.rpm =============================================================================== rpmlint session starts ============================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphz6n19uz')] checks: 31, packages: 4 nginx-mod-fancyindex.src: W: strange-permission nginx-mod-fancyindex.spec 600 ================================================ 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.4 s =============================================== Rpmlint (debuginfo) ------------------- Checking: nginx-mod-fancyindex-debuginfo-0.5.2-1.fc40.x86_64.rpm =============================================================================== rpmlint session starts ============================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzo4exr85')] checks: 31, packages: 1 ================================================ 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s =============================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_http_core_module (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_cached_time (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_conf_set_flag_slot (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_conf_set_enum_slot (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_conf_set_num_slot (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_conf_set_str_slot (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_array_create (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_sprintf (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_utf8_cpystrn (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_create_temp_buf (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_regex_exec_array (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_utf8_length (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_http_send_header (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_gmtime (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_open_dir (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_read_file (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_strcasecmp (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_escape_html (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_escape_uri (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_palloc (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_http_output_filter (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_snprintf (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_array_push (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_pcalloc (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_log_error_core (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_cpystrn (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_strncasecmp (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_http_map_uri_to_path (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_read_dir (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_regex_compile (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_http_subrequest (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_conf_log_error (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) nginx-mod-fancyindex.x86_64: W: undefined-non-weak-symbol /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so ngx_http_send_special (/usr/lib64/nginx/modules/ngx_http_fancyindex_module.so) 3 packages and 0 specfiles checked; 0 errors, 33 warnings, 0 badness; has taken 0.4 s Unversioned so-files -------------------- nginx-mod-fancyindex: /usr/lib64/nginx/modules/ngx_http_fancyindex_module.so Source checksums ---------------- https://keys.openpgp.org/vks/v1/by-fingerprint/5AA3BC334FD7E3369E7C77B291C559DBE4C9123B : CHECKSUM(SHA256) this package : 396aeebb09113001cc4f885a2259a2e999720e32f141cce55f88beba224c7629 CHECKSUM(SHA256) upstream package : 396aeebb09113001cc4f885a2259a2e999720e32f141cce55f88beba224c7629 https://github.com/aperezdc/ngx-fancyindex/releases/download/v0.5.2/ngx-fancyindex-0.5.2.tar.xz.sig : CHECKSUM(SHA256) this package : bef9409e24e9e5d89345754e190f6d71e9ff976fe08262e35ed30f98af3d7c92 CHECKSUM(SHA256) upstream package : bef9409e24e9e5d89345754e190f6d71e9ff976fe08262e35ed30f98af3d7c92 https://github.com/aperezdc/ngx-fancyindex/releases/download/v0.5.2/ngx-fancyindex-0.5.2.tar.xz : CHECKSUM(SHA256) this package : 04c3d098ed5d8d6016d92a784c7f7692dd8cd65603a7e7d59dd3d4bbdc374656 CHECKSUM(SHA256) upstream package : 04c3d098ed5d8d6016d92a784c7f7692dd8cd65603a7e7d59dd3d4bbdc374656 Requires -------- nginx-mod-fancyindex (rpmlib, GLIBC filtered): libc.so.6()(64bit) nginx nginx(abi) rtld(GNU_HASH) nginx-mod-fancyindex-debuginfo (rpmlib, GLIBC filtered): nginx-mod-fancyindex-debugsource (rpmlib, GLIBC filtered): Provides -------- nginx-mod-fancyindex: nginx-mod-fancyindex nginx-mod-fancyindex(x86-64) nginx-mod-fancyindex-debuginfo: debuginfo(build-id) nginx-mod-fancyindex-debuginfo nginx-mod-fancyindex-debuginfo(x86-64) nginx-mod-fancyindex-debugsource: nginx-mod-fancyindex-debugsource nginx-mod-fancyindex-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/asn/workspace/package/fedora/REVIEW/2235167-nginx-mod-fancyindex/srpm/nginx-mod-fancyindex.spec 2023-10-20 16:46:07.438465603 +0200 +++ /home/asn/workspace/package/fedora/REVIEW/2235167-nginx-mod-fancyindex/srpm-unpacked/nginx-mod-fancyindex.spec 2023-10-20 02:00:00.000000000 +0200 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.5) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: nginx-mod-fancyindex Version: 0.5.2 @@ -56,3 +66,4 @@ %changelog -%autochangelog +* Fri Oct 20 2023 John Doe <packager> - 0.5.2-1 +- Uncommitted changes Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2235167 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: fonts, Python, Haskell, Java, Perl, R, Ocaml, SugarActivity, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/nginx-mod-fancyindex