Bug 2235308 - After upgrade to 4.10.2->4.10.9 hco.spec.workloadUpdateStrategy value is getting overwritten
Summary: After upgrade to 4.10.2->4.10.9 hco.spec.workloadUpdateStrategy value is gett...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Installation
Version: 4.10.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.11.2
Assignee: Simone Tiraboschi
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On: 2151693
Blocks: 2153849
TreeView+ depends on / blocked
 
Reported: 2023-08-28 11:30 UTC by Juan Orti Alcaine
Modified: 2023-09-16 18:29 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 2151693
Environment:
Last Closed: 2023-08-28 15:45:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker CNV-32685 0 None None None 2023-09-06 13:05:25 UTC
Red Hat Knowledge Base (Solution) 7030885 0 None None None 2023-08-29 06:48:09 UTC

Comment 1 Juan Orti Alcaine 2023-08-28 11:34:53 UTC
Cloning this bug to the 4.10 version because customer is hitting this problem while upgrading the Openshift Virtualization operator from 4.10.2 to 4.10.9.

Before the upgrade they configure:

```
spec:
  workloadUpdateStrategy:
    workloadUpdateMethods:
    - LiveMigrate
    - Evict
```

When 4.10.9 is installed, workloadUpdateMethods has been overwritten.

Comment 2 Simone Tiraboschi 2023-08-28 15:45:01 UTC
Technically the upgrade from 4.10.2 to 4.10.9 should not be strictly considered part of the EUS->EUS upgrade process but just as a preliminary step.
If we want to avoid upgrading migrating/restarting all the VMs to upgrade the virt-launcher image (with qemu and libvirt binaries) knowing that it's going to happen soon once at 4.12, we can still use a workaround there:

An invalid configuration like:
```
spec:
  workloadUpdateStrategy:
    workloadUpdateMethods:
    - None
```
should not cause any side effect with the wrong value being simply ignored, see:
https://github.com/kubevirt/kubevirt/blob/release-0.49/pkg/virt-controller/watch/workload-updater/workload-updater.go#L295-L301

on the other side, having a placeholder value there will be enough to prevent it from getting overwritten with its default configuration.
Looking at the code, the placeholder value can be safely kept in place till the cluster reaches 4.12.


Note You need to log in before you can comment on or make changes to this bug.