Bug 2235544 - Review Request: ogmtools - Tools for Ogg media streams
Summary: Review Request: ogmtools - Tools for Ogg media streams
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL: https://www.bunkus.org/videotools/ogm...
Whiteboard:
Depends On:
Blocks: MultimediaSIG
TreeView+ depends on / blocked
 
Reported: 2023-08-29 01:08 UTC by Davide Cavalca
Modified: 2023-09-15 18:49 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-14 01:27:59 UTC
Type: ---
Embargoed:
dominik: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-08-29 01:08:36 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/ogmtools/ogmtools.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/ogmtools/ogmtools-1.5-34.fc40.src.rpm

Description:
These tools allow information about (ogminfo) or extraction from (ogmdemux) or
creation of (ogmmerge) OGG media streams. Note that OGM is used for "OGG media
streams".

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-08-29 01:08:39 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=105462816

Comment 2 Davide Cavalca 2023-08-29 01:09:01 UTC
This package will need to be unretired: https://src.fedoraproject.org/rpms/ogmtools

Comment 3 Fedora Review Service 2023-08-29 01:16:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6351261
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235544-ogmtools/fedora-rawhide-x86_64/06351261-ogmtools/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Dominik 'Rathann' Mierzejewski 2023-09-04 09:03:43 UTC
The Provides: for bundled avilib are missing.

Other than that, it looks good.

Package builds in mock.
License field is correct SPDX identifier.
Source matches upstream.
Spec file is legible and uses modern macros.
rpmlint output is acceptable (only complains about old FSF address, as expected).

Please add the missing Provides: when importing.

APPROVED.

Comment 5 Dominik 'Rathann' Mierzejewski 2023-09-04 09:18:32 UTC
Also, please drop --disable-dependency-tracking from %configure call.
It's already there in the macro, no need to repeat it.

Comment 6 Davide Cavalca 2023-09-04 13:24:47 UTC
Thanks! Unretirement ticket: https://pagure.io/releng/issue/11658

Comment 7 Fedora Update System 2023-09-05 15:09:12 UTC
FEDORA-2023-e96fcba053 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e96fcba053

Comment 8 Fedora Update System 2023-09-05 15:22:10 UTC
FEDORA-2023-a3b3d8e2fb has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a3b3d8e2fb

Comment 9 Fedora Update System 2023-09-06 01:24:42 UTC
FEDORA-2023-a3b3d8e2fb has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a3b3d8e2fb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a3b3d8e2fb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-09-06 01:33:09 UTC
FEDORA-2023-e96fcba053 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e96fcba053 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e96fcba053

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-09-14 01:27:59 UTC
FEDORA-2023-a3b3d8e2fb has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-09-15 18:49:25 UTC
FEDORA-2023-e96fcba053 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.