Spec URL: https://1707.io/jz/kf6.spec SRPM URL: https://1707.io/jz/kf6-6-1.fc38.src.rpm Description: Fedora Account System Username: justinz
Copr build: https://copr.fedorainfracloud.org/coprs/build/6351459 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2235550-kf6/fedora-rawhide-x86_64/06351459-kf6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Initial spec review: > License: BSD This is no longer valid, we need it to be a valid SPDX license Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names We don't seem to have a license text to go with this, and neither does kf5 (which it was forked from). We should be able to go ahead and put in a BSD-3-Clause license file in both projects and just set this to BSD-3-Clause, though. > %if 0%{?fedora} || 0%{?rhel} > 7 > Requires: cmake >= 3 > Requires: qt6-rpm-macros >= 6 > %else > Requires: cmake3 > Requires: qt6-qtbase-devel >= 6 > %endif We are not building this for anything older than EPEL 9, so we can simplify this logic to: Requires: cmake >= 3 Requires: qt6-rpm-macros >= 6 > %if 0%{?rhel} == 8 > # This is where cmake-related macros live, e.g. %%cmake_build, %%cmake_install > # at least until fixed upstream, https://bugzilla.redhat.com/show_bug.cgi?id=1858941 > Requires: epel-rpm-macros > %endif This can be dropped. This was fixed a long time ago. Same for in EPEL 8. > %if 0%{?rhel} && 0%{?rhel} < 8 > -e 's|%{__cmake}|%{__cmake3}|' \ > %endif This can be dropped.
(In reply to Neal Gompa from comment #3) > > > %if 0%{?rhel} == 8 > > # This is where cmake-related macros live, e.g. %%cmake_build, %%cmake_install > > # at least until fixed upstream, https://bugzilla.redhat.com/show_bug.cgi?id=1858941 > > Requires: epel-rpm-macros > > %endif > > This can be dropped. This was fixed a long time ago. Same for in EPEL 8. > Sorry, I meant same for kf5.
Updated with all requested changes.
Review notes: * Package complies with Fedora Packaging Guidelines * Package builds and installs * Package licensing is correct and license file is correctly installed * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6