Bug 2236248 - Review Request: get_iplayer - Lists, records and streams BBC iPlayer TV and radio programmes
Summary: Review Request: get_iplayer - Lists, records and streams BBC iPlayer TV and r...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/get-iplayer/%{name}
Whiteboard:
Depends On:
Blocks: MultimediaSIG
TreeView+ depends on / blocked
 
Reported: 2023-08-30 19:36 UTC by Davide Cavalca
Modified: 2023-12-23 04:40 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 6356988 to 6357000 (944 bytes, patch)
2023-08-30 19:56 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 6357000 to 6784937 (3.39 KB, patch)
2023-12-23 04:40 UTC, Fedora Review Service
no flags Details | Diff

Description Davide Cavalca 2023-08-30 19:36:55 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer-3.31-3.fc40.src.rpm

Description:
get_iplayer is a tool for listing, recording and streaming BBC iPlayer
television and radio programmes, and other programmes via 3rd-party
plugins.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-08-30 19:36:57 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=105541483

Comment 2 Davide Cavalca 2023-08-30 19:37:32 UTC
This is based on the rpmfusion package: https://admin.rpmfusion.org/pkgdb/package/free/get_iplayer/

Comment 3 Davide Cavalca 2023-08-30 19:44:43 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer-3.31-4.fc40.src.rpm

Changelog:
- Merge latest changes from rpmfusion

Comment 4 Fedora Review Service 2023-08-30 19:48:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6356988
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2236248-get_iplayer/fedora-rawhide-x86_64/06356988-get_iplayer/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2023-08-30 19:56:07 UTC
Created attachment 1986198 [details]
The .spec file difference from Copr build 6356988 to 6357000

Comment 6 Fedora Review Service 2023-08-30 19:56:10 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6357000
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2236248-get_iplayer/fedora-rawhide-x86_64/06357000-get_iplayer/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Dominik 'Rathann' Mierzejewski 2023-11-19 21:40:22 UTC
Please split all the BuildRequires into one per line and sort alphabetically.

BuildRequires:  file-libs >= 5.14-14

That is an unusual requirement for a noarch package. What is actually required here?

%build
./get_iplayer --manpage=get_iplayer.1 || :

What is getting "built" here? The manpage?

Requires:       perl(Encode::Locale)
Requires:       perl(XML::LibXML) >= 1.91
Requires:       perl(LWP::Protocol::https)
Requires:       perl(Mojolicious) >= 4.63
Requires:       perl(JSON::PP)

Are these perl requirements not detected automatically?

Comment 8 Davide Cavalca 2023-12-22 16:58:45 UTC
> Please split all the BuildRequires into one per line and sort alphabetically.

Will do

> That is an unusual requirement for a noarch package. What is actually required here?

This was for https://bugzilla.redhat.com/show_bug.cgi?id=1051607 according to the git blame. Given that we're long past that I'll just drop it.

> What is getting "built" here? The manpage?

Yup, I'll add a comment

> Are these perl requirements not detected automatically?

perl(Encode::Locale) and perl(Mojolicious) >= 4.63 are missing, the rest is there so I'll drop them.

Comment 9 Davide Cavalca 2023-12-22 17:02:12 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/get_iplayer/get_iplayer-3.34-2.fc40.src.rpm

Changelog:
- Merge latest changes from rpmfusion
- Tidy up requires and BuildRequires

Comment 10 Fedora Review Service 2023-12-23 04:40:12 UTC
Created attachment 2005573 [details]
The .spec file difference from Copr build 6357000 to 6784937

Comment 11 Fedora Review Service 2023-12-23 04:40:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6784937
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2236248-get_iplayer/fedora-rawhide-x86_64/06784937-get_iplayer/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.