Overcloud nodes are deployed without banner text message, even if one was configured.
If I understand correctly, the condition used to set 'tripleo_sshd_banner_enabled' in tripleo template file 'sshd-baremetal-ansible.yaml' seems to be inverted:


BannerText sets an empty string as default:
 ~~~
   BannerText:
     default: ''
     description: Configures Banner text in sshd_config
     type: string
 ~~~


ssh_banner_text_empty fetches the value of BannerText and checks if it is equal to '' (empty).
If BannerText is empty, ssh_banner_text_empty value will be true. 
If BannerText contains data, ssh_banner_text_empty value will be false.  #<--- should be set 'false' in test case [1]
 ~~~
 conditions:
   ssh_banner_text_empty: {equals: [{get_param: BannerText}, '']}
 ~~~


Variable tripleo_sshd_banner_enabled is defined by the 'if' statement.
If ssh_banner_text_empty is true, then tripleo_sshd_banner_enabled will be set to true.
If ssh_banner_text_empty is false, then tripleo_sshd_banner_enabled will be set to false.
 ~~~
             tripleo_sshd_banner_enabled:
               if:
                 - ssh_banner_text_empty
                 - true   # <--- should be false?
                 - false   # <--- should be true?
 ~~~


[1] Truncated from extraconfig.yaml
parameter_defaults:
  BannerText: |
    TEST MESSAGE

Reproducible: Always

Actual Results:  
[stack@undercloud ~]$ grep -A2 tripleo_sshd_banner_enabled ./overcloud-deploy/overcloud/config-download/overcloud/Compute/host_prep_tasks.yaml
    tripleo_sshd_banner_enabled: false 
    tripleo_sshd_banner_text: 'TEST MESSAGE'

Expected Results:  
[stack@undercloud ~]$ grep -A2 tripleo_sshd_banner_enabled ./overcloud-deploy/overcloud/config-download/overcloud/Compute/host_prep_tasks.yaml
    tripleo_sshd_banner_enabled: true 
    tripleo_sshd_banner_text: 'TEST MESSAGE'

-A customer raised this issue
-I checked the follwing: https://opendev.org/openstack/tripleo-heat-templates/src/branch/stable/wallaby/deployment/sshd/sshd-baremetal-ansible.yaml
-Also validated we have the same in a RHOSP17.1 lab (Red Hat OpenStack Platform release 17.1.0 (Wallaby))
-Variable 'tripleo_sshd_motd_enabled' seems to have the same inverted logic but was not tested yet.