Bug 223704 - krb5: non-failsafe install-info use in scriptlets
Summary: krb5: non-failsafe install-info use in scriptlets
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: krb5
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nalin Dahyabhai
QA Contact: Brian Brock
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-21 20:47 UTC by Ville Skyttä
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-01-23 17:03:18 UTC
Type: ---


Attachments (Terms of Use)
Make install-info use in scriptlets failsafe (977 bytes, patch)
2007-01-21 20:47 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2007-01-21 20:47:31 UTC
krb5's install-info use in scriptlets is not failsafe, fix attached.  More info:
http://www.redhat.com/archives/fedora-maintainers/2007-January/msg00017.html

Comment 1 Ville Skyttä 2007-01-21 20:47:31 UTC
Created attachment 146127 [details]
Make install-info use in scriptlets failsafe

Comment 2 Nalin Dahyabhai 2007-01-22 19:53:25 UTC
For future reference, what's the rule here?  If we call install-info last, we
explicitly return 0, or is it that we need to if we call install-info at all?

Comment 3 Ville Skyttä 2007-01-23 17:01:52 UTC
The scriptlet's exit code is the one of the last command executed in it, and
execution does not (as of now) stop if an intermediate command returns non-zero.
 So if there are commands after install-info that are not known to fail in
"normal" situations (such as %_excludedocs or read-only /usr/share), an explicit
zero exit code is not needed.

Comment 4 Ville Skyttä 2007-01-23 17:03:18 UTC
Oh, and this seems to be fixed in CVS, thanks.


Note You need to log in before you can comment on or make changes to this bug.