Bug 2237101 (rust-include_dir) - Review Request: rust-include_dir - Embed the contents of a directory in your binary
Summary: Review Request: rust-include_dir - Embed the contents of a directory in your ...
Keywords:
Status: CLOSED NOTABUG
Alias: rust-include_dir
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: rust-include_dir_macros
Blocks: FE-DEADREVIEW espanso
TreeView+ depends on / blocked
 
Reported: 2023-09-03 15:40 UTC by Robert-André Mauchin 🐧
Modified: 2024-05-19 00:45 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-05-19 00:45:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2023-09-03 15:40:43 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-include_dir.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-include_dir-0.7.3-1.fc38.src.rpm

Description:
Embed the contents of a directory in your binary.

Fedora Account System Username: eclipseo

To build it against the dependencies, use the following COPR in your rawhide mock.cfg:

[copr:copr.fedorainfracloud.org:eclipseo:espanso]
name=Copr repo for espanso owned by eclipseo
baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/espanso/fedora-rawhide-/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/espanso/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Fabio Valentini 2023-09-05 13:43:19 UTC
Package looks good so far, I'll continue with the review once include_dir_macros are imported.

But adding a comment why integration tests are disabled would be good:
> rm -rfv tests/

Alternatively, you can keep the files and change the %cargo_test arguments:

%cargo_test -- --lib
%cargo_test -- --doc

Comment 2 Fabio Valentini 2024-04-18 14:48:10 UTC
Robert, are you still interested in this package?

Comment 3 Package Review 2024-05-19 00:45:36 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.