Bug 2237105 (rust-pipeline) - Review Request: rust-pipeline - Macro collection to pipe |> your functions calls, like in F# or Elixir [NEEDINFO]
Summary: Review Request: rust-pipeline - Macro collection to pipe |> your functions ca...
Keywords:
Status: POST
Alias: rust-pipeline
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: rust-markdown
TreeView+ depends on / blocked
 
Reported: 2023-09-03 15:41 UTC by Robert-André Mauchin 🐧
Modified: 2023-12-04 16:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review+
decathorpe: needinfo? (zebob.m)


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2023-09-03 15:41:29 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-pipeline.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-pipeline-0.5.0-1.fc38.src.rpm

Description:
A macro collection to pipe |> your functions calls, like in F# or Elixir.

Fedora Account System Username: eclipseo

To build it against the dependencies, use the following COPR in your rawhide mock.cfg:

[copr:copr.fedorainfracloud.org:eclipseo:espanso]
name=Copr repo for espanso owned by eclipseo
baseurl=https://download.copr.fedorainfracloud.org/results/eclipseo/espanso/fedora-rawhide-/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/eclipseo/espanso/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Fabio Valentini 2023-09-04 10:37:58 UTC
Looks good to me, but why are you overriding the URL tag?

-URL:            https://espanso.org/
+URL:            https://crates.io/crates/pipeline

Comment 2 Robert-André Mauchin 🐧 2023-10-24 19:57:45 UTC
Thanks for taking a look!

Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-pipeline.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-pipeline-0.5.0-1.fc39.src.rpm

Comment 3 Fabio Valentini 2023-10-24 20:35:25 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fabio Valentini 2023-12-04 16:09:23 UTC
Please continue with requesting the repo + importing the package - I see this is blocking other things that you've been working on.


Note You need to log in before you can comment on or make changes to this bug.