Bug 2237666 - Review Request: golang-github-google-s2a - Secure Session Agent Client Libraries
Summary: Review Request: golang-github-google-s2a - Secure Session Agent Client Libraries
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Solovev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-06 09:00 UTC by Robert-André Mauchin 🐧
Modified: 2023-11-03 18:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-16 00:43:10 UTC
Type: ---
Embargoed:
daron439: fedora-review+


Attachments (Terms of Use)

Description Robert-André Mauchin 🐧 2023-09-06 09:00:33 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-google-s2a.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-google-s2a-0.1.7-1.fc38.src.rpm

Description:
The Secure Session Agent is a service that enables a workload to offload select operations from the mTLS handshake and protects a workload's private key material from exfiltration. Specifically, the workload asks the Secure Session Agent for the TLS configuration to use during the handshake, to perform private key operations, and to validate the peer certificate chain. The Secure Session Agent's client libraries enable applications to communicate with the Secure Session Agent during the TLS handshake, and to encrypt traffic to the peer after the TLS handshake is complete.  This repository contains the source code for the Secure Session Agent's Go client libraries, which allow gRPC and HTTP Go applications to use the Secure Session Agent.

Fedora Account System Username: eclipseo

Comment 1 Pavel Solovev 2023-10-07 09:13:09 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 2 Fedora Admin user for bugzilla script actions 2023-10-07 18:26:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-s2a

Comment 3 Robert-André Mauchin 🐧 2023-10-07 18:26:00 UTC
Thank you for the review, Pavel

https://pagure.io/releng/fedora-scm-requests/issue/56850

Comment 4 Fedora Update System 2023-10-07 19:21:19 UTC
FEDORA-2023-a079ff608b has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a079ff608b

Comment 5 Fedora Update System 2023-10-07 19:34:35 UTC
FEDORA-2023-c53b9e83de has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c53b9e83de

Comment 6 Fedora Update System 2023-10-08 01:21:46 UTC
FEDORA-2023-c53b9e83de has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c53b9e83de \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c53b9e83de

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-10-08 01:22:20 UTC
FEDORA-2023-a079ff608b has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a079ff608b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a079ff608b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-10-16 00:43:10 UTC
FEDORA-2023-c53b9e83de has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-11-03 18:32:21 UTC
FEDORA-2023-a079ff608b has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.