Bug 2237982 - Review Request: python-inkex - Python extensions for Inkscape core
Summary: Review Request: python-inkex - Python extensions for Inkscape core
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2237995
TreeView+ depends on / blocked
 
Reported: 2023-09-08 08:25 UTC by Benson Muite
Modified: 2023-09-17 01:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-17 01:26:19 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Benson Muite 2023-09-08 08:25:49 UTC
spec: https://download.copr.fedorainfracloud.org/results/fed500/python-svg2tikz/fedora-rawhide-x86_64/06384608-python-inkex/python-inkex.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/python-svg2tikz/fedora-rawhide-x86_64/06384608-python-inkex/python-inkex-1.3.0-1.fc40.src.rpm

Description:
This package supports Inkscape extensions.

It provides
- a simplification layer for SVG manipulation through lxml
- base classes for common types of Inkscape extensions
- simplified testing of those extensions
- a user interface library based on GTK3

At its core, Inkscape extensions take in a file, and output a file.
- For effect extensions, those two files are SVG files.
- For input extensions, the input file may be any arbitrary
  file and the output is an SVG.
- For output extensions, the input is an SVG file while the
  output is an arbitrary file.
- Some extensions (e.g. the extensions manager) don't manipulate files.

This folder also contains the stock Inkscape extensions, i.e. the scripts
that implement some commands that you can use from within Inkscape.
Most of these commands are in the Extensions menu, or in the Open /
Save dialogs.

fas: fed500

Reproducible: Always

Comment 1 José Matos 2023-09-08 11:36:34 UTC
Hi Benson,
  I am taking this review (and the other related). Please take in exchange
https://bugzilla.redhat.com/show_bug.cgi?id=2237950

Comment 2 José Matos 2023-09-08 11:58:40 UTC
Review notes:

* Package follows packaging guidelines (it is a simple python package and macros do most of the work) :-)
* Package builds and installs properly
* Package licensing is correct and license files are collected

There are two remarks to do regarding the license:
1) rpmlint complains:
python3-inkex.noarch: E: incorrect-fsf-address /usr/lib/python3.12/site-packages/inkex-1.3.0.dist-info/LICENSE.txt

so basically the address of FSF is outdated. This issue needs to be fixed in the upstream project and not here, please warn them.

2) The license file is packaged but not marked as such:
  Note: License file LICENSE.txt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

Fix this on import.

Otherwise, this is good to go...

PACKAGE APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-09-08 14:58:33 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-inkex

Comment 4 Fedora Update System 2023-09-08 15:30:26 UTC
FEDORA-2023-7690b3a24a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7690b3a24a

Comment 5 Fedora Update System 2023-09-08 15:46:16 UTC
FEDORA-2023-b9de210cf4 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9de210cf4

Comment 6 Benson Muite 2023-09-08 20:05:18 UTC
Thanks. https://gitlab.com/inkscape/extensions/-/issues/555

Comment 7 Fedora Update System 2023-09-09 01:50:25 UTC
FEDORA-2023-7690b3a24a has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7690b3a24a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7690b3a24a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-09-09 02:34:27 UTC
FEDORA-2023-b9de210cf4 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b9de210cf4 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9de210cf4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-09-17 01:26:19 UTC
FEDORA-2023-7690b3a24a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-09-17 01:42:53 UTC
FEDORA-2023-b9de210cf4 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.