Bug 2238149 - No Lua support
Summary: No Lua support
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pandoc
Version: 39
Hardware: Unspecified
OS: Linux
high
urgent
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-09 12:47 UTC by Iñaki Ucar
Modified: 2023-11-03 18:25 UTC (History)
5 users (show)

Fixed In Version: pandoc-3.1.3-25.fc40 pandoc-3.1.3-25.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-03 18:25:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FC-984 0 None None None 2023-09-28 06:07:46 UTC

Description Iñaki Ucar 2023-09-09 12:47:09 UTC
Pandoc version 3 seems to have no Lua support:

```
/usr/bin/pandoc +RTS -K512m -RTS test.knit.md --to html4 --from markdown+autolink_bare_uris+tex_math_single_backslash --output test.html --lua-filter /usr/share/R/library/rmarkdown/rmarkdown/lua/pagebreak.lua --lua-filter /usr/share/R/library/rmarkdown/rmarkdown/lua/latex-div.lua --embed-resources --standalone --section-divs --template /usr/share/R/library/rmarkdown/rmd/h/default.html --highlight-style pygments --css /usr/share/R/library/rmarkdown/rmarkdown/templates/html_vignette/resources/vignette.css --mathjax --variable 'mathjax-url=https://mathjax.rstudio.com/latest/MathJax.js?config=TeX-AMS-MML_HTMLorMML' --include-in-header /tmp/RtmpiekFs9/rmarkdown-str8ae41f9fc61.html 
This version of pandoc has been compiled without Lua support.
Error: pandoc document conversion failed with error 89
```

Please, add Lua support back, this breaks a bunch of stuff.

Reproducible: Always

Steps to Reproduce:
Try to use Lua filters
Actual Results:  
Error message: This version of pandoc has been compiled without Lua support.

Expected Results:  
Lua support should be available.

Comment 1 Jens Petersen 2023-09-11 04:18:23 UTC
Good call, thanks

Comment 2 Jens Petersen 2023-09-11 06:38:31 UTC
Really wondering whether pandoc-server should be enabled or not as well...
I probably won't enable server by default for now.

Also the amount of packaging technical debt for this package is getting a bit out of control.
Help with getting new deps reviewed would be much appreciated.

Comment 3 Orion Poplawski 2023-09-20 04:17:45 UTC
What help is needed to get Lua support back?

Comment 4 Jens Petersen 2023-09-20 07:12:10 UTC
It is coming :-)

I started working on improving cabal-rpm subpackaging handling,
since it is tedious to work out the missing deps manually.
Hopefully I can finish that off this week - personal life and all that too.

If you want to help with

(In reply to Jens Petersen from comment #2)
> Also the amount of packaging technical debt for this package is getting a
> bit out of control.
> Help with getting new deps reviewed would be much appreciated.

(see https://src.fedoraproject.org/rpms/pandoc/blob/rawhide/f/pandoc.spec#_7)

you could start by reviewing https://bugzilla.redhat.com/show_bug.cgi?id=2163472

I am happy to file more review requests if people will help to review them.

Comment 5 Jens Petersen 2023-09-20 08:30:31 UTC
Also this one https://bugzilla.redhat.com/show_bug.cgi?id=2068718

Comment 6 Jens Petersen 2023-09-27 03:38:31 UTC
Okay little progress update: you can try this pandoc-cli scratch build locally if you want

https://koji.fedoraproject.org/koji/taskinfo?taskID=106771401

which should have lua enabled.

For example it should be installable on F39+ with `koji-tool install 106771401 -p pandoc-cli`.

Comment 7 Jens Petersen 2023-09-27 03:41:52 UTC
And (probably noone cares), these are the changes I am making to cabal-rpm to implement this:

 cabal-rpm.cabal           |    6 +++
 src/Commands/Spec.hs      |   74 +++++++++++++++++++------------------
 src/Dependencies.hs       |   44 ++++++++++++++--------
 src/PackageUtils.hs       |   22 ++++++++++-
 src/Stackage.hs           |   92 ++++++++++++++++++++++++++++++----------------
 src/Stackage/MajorVer.hs  |   77 ++++++++++++++++++++++++++++++++++++++
 src/Stackage/Snapshots.hs |   45 ++++++++++++++++++++++
 7 files changed, 278 insertions(+), 82 deletions(-)

Though the main packaging painpoint was that pandoc-cli wasn't included in Stackage LTS 21 :-(

Next I will fold pandoc-cli.spec into pandoc.spec <sadface/>

Comment 8 Jens Petersen 2023-09-27 18:05:53 UTC
(I released cabal-rpm-2.1.3 for this)

I kicked off a pandoc scratch build, which I hope should fix this:
https://koji.fedoraproject.org/koji/taskinfo?taskID=106797301

Testing would be appreciated, once it finishes.

If all goes well I should be able to start a sidetag tomorrow to build it for Rawhide.

Comment 9 Jens Petersen 2023-09-28 04:31:46 UTC
Any examples of how to test this?

I was looking for any build failures in Koji but didn't find any so far...

It would be helpful to have that info in the bug report :-)

Comment 10 Jens Petersen 2023-09-28 04:59:00 UTC
Alright I just tested with the first example from https://pandoc.org/lua-filters.html
and that works for me, so hopefully this will be good now.

f39$ echo '**hello**' | /usr/bin/pandoc --lua-filter ./smallcaps.lua
This version of pandoc has been compiled without Lua support.

f40$ echo '**hello**' | /usr/bin/pandoc --lua-filter ./smallcaps.lua
<p><span class="smallcaps">hello</span></p>

Comment 11 Jens Petersen 2023-09-28 05:40:08 UTC
For this who want to follow closely you can track the rawhide builds in f40-build-side-74646

Comment 12 Jens Petersen 2023-09-28 06:46:55 UTC
https://src.fedoraproject.org/rpms/pandoc/c/6accb5f214a2b97e020acc2a16a837fe1ddd73f0?branch=rawhide

 .gitignore  |   12 +
 pandoc.spec |  580 ++++++++++++++++++++++++++++++++++++++++++++++--------------
 sources     |   29 +--
 3 files changed, 484 insertions(+), 137 deletions(-)


Also you can see there the ridiculous number of dependencies subpackaged (27 libs now).
If you depend on and care about pandoc in Fedora, do please help to review package review requests for this
(most are still pending to be submitted).

Comment 13 Ed Santiago 2023-09-28 19:51:56 UTC
@petersen's build from comment 12 installs cleanly on f39 and works, at least from the perspective of podman CI. Thank you!

Comment 14 Jens Petersen 2023-09-29 07:10:50 UTC
I am disabling LUA on ppc64le, to stop it crashing... (see bug 2172771)

Comment 15 Jens Petersen 2023-09-29 07:11:23 UTC
(In reply to Ed Santiago from comment #13)
> @petersen's build from comment 12 installs cleanly on f39 and works, at
> least from the perspective of podman CI. Thank you!

Thanks for testing, Ed

Comment 16 Jens Petersen 2023-09-29 09:10:19 UTC
This has now been merged into Rawhide.

More testing is welcome - and I will build it for F39 next.

Comment 17 Jens Petersen 2023-09-29 09:11:02 UTC
Rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f8dffe28da

Comment 18 Fedora Update System 2023-09-29 13:54:31 UTC
FEDORA-2023-aa61077305 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-aa61077305

Comment 19 Fedora Update System 2023-09-30 03:30:31 UTC
FEDORA-2023-aa61077305 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-aa61077305`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-aa61077305

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 20 Fedora Update System 2023-11-03 18:25:10 UTC
FEDORA-2023-aa61077305 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.