Spec URL: https://ngompa.fedorapeople.org/for-review/libdatachannel.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/libdatachannel-0.19.1-1.fc38.src.rpm Description: libdatachannel is a standalone implementation of WebRTC Data Channels, WebRTC Media Transport, and WebSockets in C++17 with C bindings for POSIX platforms (including GNU/Linux, Android, FreeBSD, Apple macOS and iOS) and Microsoft Windows. Fedora Account System Username: ngompa
> #BuildRequires: cmake(LibJuice) Did you mean to leave this commented out? Add a comment explaining why if it's on purpose
(In reply to Davide Cavalca from comment #1) > > #BuildRequires: cmake(LibJuice) > > Did you mean to leave this commented out? Add a comment explaining why if > it's on purpose Yes. I added a comment about it not being needed yet and not being packaged in Fedora yet.
Created attachment 1988195 [details] review Attaching the fedora-review review as it's too long for a comment due to rpmlint output
- Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 105225510 bytes in 2544 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 57600000 bytes in /usr/share libdatachannel-devel-0.19.1-1.fc40.x86_64.rpm:57579520 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines These should be fixed by making the appropriate subpackages. There's also a ton of rpmlint warnings as it tries to parse binary samples as text files. Not sure what the right course of action is here, but probably worth reporting to rpmlint at least. Besides this, APPROVED.
I think I'll just not ship the examples then, I didn't expect it to be quite so angry about it...
The Pagure repository was created at https://src.fedoraproject.org/rpms/libdatachannel
FEDORA-2023-9024d60a5e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9024d60a5e
FEDORA-2023-543c5612db has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-543c5612db
FEDORA-2023-5123efa972 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5123efa972
FEDORA-2023-543c5612db has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-543c5612db` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-543c5612db See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-9024d60a5e has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9024d60a5e \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9024d60a5e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-5123efa972 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5123efa972 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5123efa972 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-5123efa972 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-9024d60a5e has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-543c5612db has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.